github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-31 10:33:41 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

wifi: iwlwifi: tests: simplify devinfo_no_trans_cfg_dups()

Browse Source 
There's no need to build a list of individual configs
first and then compare them, we can just go through all
of them and compare if the pointers aren't the same.
The complexity (in terms of number of comparisons) is a
bit higher that way, but it's just a test and the code
complexity is much lower without that.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20250504132447.85911c59d96a.I540f464229da3566d1726dfb61b46002fbb73bde@changeid
This commit is contained in:
Johannes Berg 2025-05-04 13:26:29 +03:00 committed by Miri Korenblit
parent 5f585528ff
commit d6bf0778f7
1 changed files with 11 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
drivers/net/wireless/intel/iwlwifi/tests/devinfo.c
View File

@ -157,43 +157,21 @@ static void devinfo_pci_ids(struct kunit *test)
static void devinfo_no_trans_cfg_dups(struct kunit *test)
{
/* allocate iwl_dev_info_table_size as upper bound */
const struct iwl_cfg_trans_params **cfgs;
int count = 0;
int p = 0;
for (int i = 0; iwl_hw_card_ids[i].vendor; i++)
count++;
cfgs = kunit_kcalloc(test, count, sizeof(*cfgs), GFP_KERNEL);
KUNIT_ASSERT_NOT_NULL(test, cfgs);
/* build a list of unique (by pointer) configs first */
for (int i = 0; iwl_hw_card_ids[i].vendor; i++) {
struct iwl_cfg_trans_params *cfg;
bool found = false;
const struct iwl_cfg_trans_params *cfg_i =
(void *)iwl_hw_card_ids[i].driver_data;
cfg = (void *)iwl_hw_card_ids[i].driver_data;
for (int j = 0; j < p; j++) {
if (cfgs[j] == cfg) {
found = true;
break;
}
}
if (!found) {
cfgs[p] = cfg;
p++;
}
}
/* check that they're really all different */
for (int i = 0; i < p; i++) {
for (int j = 0; j < i; j++) {
KUNIT_EXPECT_NE_MSG(test, memcmp(cfgs[i], cfgs[j],
sizeof(*cfgs[i])), 0,
const struct iwl_cfg_trans_params *cfg_j =
(void *)iwl_hw_card_ids[j].driver_data;
if (cfg_i == cfg_j)
continue;
KUNIT_EXPECT_NE_MSG(test, memcmp(cfg_j, cfg_i,
sizeof(*cfg_i)), 0,
"identical configs: %ps and %ps\n",
cfgs[i], cfgs[j]);
cfg_i, cfg_j);
}
}
}