github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-22 12:44:03 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

pinctrl: sx150x: get parent IRQ trigger type from firmware

Browse Source 
The driver currently hardcodes the parent interrupt trigger type to
IRQF_TRIGGER_FALLING.

Use the trigger type configured by firmware instead. If no trigger type
is specified, fall back to IRQF_TRIGGER_FALLING to maintain current
behaviour.

Support IRQF_TRIGGER_FALLING and IRQF_TRIGGER_LOW, which match the
sx150x open drain active low interrupt output. Reject unsupported
trigger types.

Signed-off-by: Tsz Shan Chan <tchan@jacques.com.au>
Signed-off-by: Linus Walleij <linusw@kernel.org>
This commit is contained in:
Tsz Shan Chan 2026-08-05 15:55:16 +10:00 committed by Linus Walleij
parent c04957d2fc
commit d4f32b8b8a
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/pinctrl/pinctrl-sx150x.c
View File

@ -1126,6 +1126,7 @@ static int sx150x_probe(struct i2c_client *client)
I2C_FUNC_SMBUS_WRITE_WORD_DATA;
struct device *dev = &client->dev;
struct sx150x_pinctrl *pctl;
u32 irq_type;
int ret;
if (!i2c_check_functionality(client->adapter, i2c_funcs))
@ -1225,10 +1226,24 @@ static int sx150x_probe(struct i2c_client *client)
girq->handler = handle_bad_irq;
girq->threaded = true;
irq_type = irq_get_trigger_type(client->irq);
switch (irq_type) {
case IRQF_TRIGGER_FALLING:
case IRQF_TRIGGER_LOW:
break;
case IRQF_TRIGGER_NONE:
irq_type = IRQF_TRIGGER_FALLING;
break;
default:
return dev_err_probe(dev, -EINVAL,
"unsupported irq trigger type %x\n",
irq_type);
}
ret = devm_request_threaded_irq(dev, client->irq, NULL,
sx150x_irq_thread_fn,
IRQF_ONESHOT | IRQF_SHARED |
IRQF_TRIGGER_FALLING,
irq_type,
client->name, pctl);
if (ret < 0)
return ret;