github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-07 06:17:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

swim: Define macros for constants

Browse Source 
Define a SEL_MASK macro to name the anonymous constant. Define STEPPING
rather than re-use STEP because the latter is a command bit macro (see also
GCR_MODE vs. SETGCR). No functional change, just better readability.

Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Finn Thain <fthain@linux-m68k.org>
Tested-by: Stan Johnson <userm57@yahoo.com>
Link: https://patch.msgid.link/64ee742adc48218962a989017b9dc5622e2932c7.1788513997.git.fthain@linux-m68k.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Finn Thain 2026-09-04 19:26:36 +10:00 committed by Jens Axboe
parent e97cbb470c
commit d4b2519065
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/block/swim.c
View File

@ -105,6 +105,8 @@ struct iwm {
/* Select values for swim_select and swim_readbit */
#define SEL_MASK 0x100
#define SEEK_POSITIVE 0x000
#define SEEK_NEGATIVE 0x004
#define STEP 0x001
@ -115,6 +117,7 @@ struct iwm {
#define SETMFM 0x101
#define SETGCR 0x105
#define STEPPING 0x001
#define READ_DATA_0 0x004
#define ONEMEG_DRIVE 0x005
#define SINGLE_SIDED 0x006
@ -271,7 +274,7 @@ static inline void swim_select(struct swim __iomem *base, int sel)
{
swim_write(base, phase, RELAX | PHASE_PIN_DIR);
via1_set_head(sel & 0x100);
via1_set_head(sel & SEL_MASK);
swim_write(base, phase, (sel & CA_MASK) | PHASE_PIN_DIR);
}
@ -366,7 +369,7 @@ static int swim_step(struct swim __iomem *base)
{
swim_action(base, STEP);
udelay(150);
return swim_readbit_timeout(base, STEP, false, 20 * 1000);
return swim_readbit_timeout(base, STEPPING, false, 20 * 1000);
}
static int swim_track00(struct swim __iomem *base)