NFS: return void from nfs4_inode_make_writeable

None of the callers checks the return value, so drop it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Anna Schumaker <anna.schumaker@oracle.com>
This commit is contained in:
Christoph Hellwig 2026-01-28 05:46:03 +01:00 committed by Anna Schumaker
parent 7537db2480
commit d37272c62a
2 changed files with 4 additions and 8 deletions

View File

@ -912,23 +912,19 @@ void nfs4_inode_return_delegation_on_close(struct inode *inode)
* @inode: pointer to inode
*
* Make the inode writeable by returning the delegation if necessary
*
* Returns zero on success, or a negative errno value.
*/
int nfs4_inode_make_writeable(struct inode *inode)
void nfs4_inode_make_writeable(struct inode *inode)
{
struct nfs_delegation *delegation;
int error = 0;
delegation = nfs4_get_valid_delegation(inode);
if (!delegation)
return 0;
return;
if (!nfs4_has_session(NFS_SERVER(inode)->nfs_client) ||
!(delegation->type & FMODE_WRITE))
error = nfs4_inode_return_delegation(inode);
nfs4_inode_return_delegation(inode);
nfs_put_delegation(delegation);
return error;
}
static void

View File

@ -87,7 +87,7 @@ int nfs4_check_delegation(struct inode *inode, fmode_t type);
bool nfs4_delegation_flush_on_close(const struct inode *inode);
void nfs_inode_find_delegation_state_and_recover(struct inode *inode,
const nfs4_stateid *stateid);
int nfs4_inode_make_writeable(struct inode *inode);
void nfs4_inode_make_writeable(struct inode *inode);
#endif