github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-08-01 12:11:59 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

drm/vkms: Add a validation function for VKMS configuration

Browse Source 
As the configuration will be used by userspace, add a validator to avoid
creating a broken DRM device.

For the moment, the function always returns true, but rules will be
added in future patches.

Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
Co-developed-by: José Expósito <jose.exposito89@gmail.com>
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250218101214.5790-8-jose.exposito89@gmail.com
Signed-off-by: Maxime Ripard <mripard@kernel.org>
This commit is contained in:
Louis Chauvet 2025-02-18 11:12:07 +01:00 committed by Maxime Ripard
parent 969a3a4e2b
commit d1386d721d
No known key found for this signature in database
GPG Key ID: E3EF0D6F671851C5
4 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/vkms/tests/vkms_config_test.c
View File

@ -54,6 +54,8 @@ static void vkms_config_test_default_config(struct kunit *test)
KUNIT_EXPECT_EQ(test, config->writeback, params->enable_writeback);
KUNIT_EXPECT_EQ(test, config->overlay, params->enable_overlay);
KUNIT_EXPECT_TRUE(test, vkms_config_is_valid(config));
vkms_config_destroy(config);
}

6
drivers/gpu/drm/vkms/vkms_config.c
View File

@ -51,6 +51,12 @@ void vkms_config_destroy(struct vkms_config *config)
}
EXPORT_SYMBOL_IF_KUNIT(vkms_config_destroy);
bool vkms_config_is_valid(const struct vkms_config *config)
{
return true;
}
EXPORT_SYMBOL_IF_KUNIT(vkms_config_is_valid);
static int vkms_config_show(struct seq_file *m, void *data)
{
struct drm_debugfs_entry *entry = m->private;

10
drivers/gpu/drm/vkms/vkms_config.h
View File

@ -67,6 +67,16 @@ vkms_config_get_device_name(struct vkms_config *config)
return config->dev_name;
}
/**
* vkms_config_is_valid() - Validate a configuration
* @config: Configuration to validate
*
* Returns:
* Whether the configuration is valid or not.
* For example, a configuration without primary planes is not valid.
*/
bool vkms_config_is_valid(const struct vkms_config *config);
/**
* vkms_config_register_debugfs() - Register a debugfs file to show the device's
* configuration

3
drivers/gpu/drm/vkms/vkms_output.c
View File

@ -16,6 +16,9 @@ int vkms_output_init(struct vkms_device *vkmsdev)
int writeback;
unsigned int n;
if (!vkms_config_is_valid(vkmsdev->config))
return -EINVAL;
/*
* Initialize used plane. One primary plane is required to perform the composition.
*