github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-23 22:14:03 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

drm/amdxcp: Add more checks to amdxcp

Browse Source 
Add NULL check to ddev argument and guard pdev_num against underflow.

Signed-off-by: Lijo Lazar <lijo.lazar@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
This commit is contained in:
Lijo Lazar 2026-05-19 16:05:36 +05:30 committed by Alex Deucher
parent ae16ca815d
commit d0a8f98166
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/gpu/drm/amd/amdxcp/amdgpu_xcp_drv.c
View File

@ -45,7 +45,7 @@ static const struct drm_driver amdgpu_xcp_driver = {
.minor = 0,
};
static int8_t pdev_num;
static u8 pdev_num;
static struct xcp_device *xcp_dev[MAX_XCP_PLATFORM_DEVICE];
static DEFINE_MUTEX(xcp_mutex);
@ -56,6 +56,11 @@ int amdgpu_xcp_drm_dev_alloc(struct drm_device **ddev)
char *dev_name;
int ret, i;
if (!ddev)
return -EINVAL;
BUILD_BUG_ON(MAX_XCP_PLATFORM_DEVICE >= U8_MAX);
guard(mutex)(&xcp_mutex);
if (pdev_num >= MAX_XCP_PLATFORM_DEVICE)
@ -105,7 +110,7 @@ int amdgpu_xcp_drm_dev_alloc(struct drm_device **ddev)
}
EXPORT_SYMBOL(amdgpu_xcp_drm_dev_alloc);
static void free_xcp_dev(int8_t index)
static void free_xcp_dev(uint8_t index)
{
if ((index < MAX_XCP_PLATFORM_DEVICE) && (xcp_dev[index])) {
struct platform_device *pdev = xcp_dev[index]->pdev;
@ -114,17 +119,18 @@ static void free_xcp_dev(int8_t index)
platform_device_unregister(pdev);
xcp_dev[index] = NULL;
pdev_num--;
if (pdev_num > 0)
pdev_num--;
}
}
void amdgpu_xcp_drm_dev_free(struct drm_device *ddev)
{
int8_t i;
uint8_t i;
guard(mutex)(&xcp_mutex);
for (i = 0; i < MAX_XCP_PLATFORM_DEVICE; i++) {
for (i = 0; pdev_num && i < MAX_XCP_PLATFORM_DEVICE; i++) {
if ((xcp_dev[i]) && (&xcp_dev[i]->drm == ddev)) {
free_xcp_dev(i);
break;
@ -135,7 +141,7 @@ EXPORT_SYMBOL(amdgpu_xcp_drm_dev_free);
void amdgpu_xcp_drv_release(void)
{
int8_t i;
uint8_t i;
guard(mutex)(&xcp_mutex);