github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-31 02:24:24 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

platform/x86: wireless-hotkey: Register ACPI notify handler directly

Browse Source 
To facilitate subsequent conversion of the driver to a platform one,
make it install an ACPI notify handler directly instead of using
a .notify() callback in struct acpi_driver.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/3953848.kQq0lBPeGt@rafael.j.wysocki
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
This commit is contained in:
Rafael J. Wysocki 2026-03-12 15:38:37 +01:00 committed by Ilpo Järvinen
parent 3471415c81
commit cfc897f6d3
No known key found for this signature in database
GPG Key ID: 59AC4F6153E5CE31
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/platform/x86/wireless-hotkey.c
View File

@ -71,9 +71,9 @@ static void wireless_input_destroy(struct acpi_device *device)
kfree(button);
}
static void wl_notify(struct acpi_device *acpi_dev, u32 event)
static void wl_notify(acpi_handle handle, u32 event, void *data)
{
struct wl_button *button = acpi_driver_data(acpi_dev);
struct wl_button *button = data;
if (event != 0x80) {
pr_info("Received unknown event (0x%x)\n", event);
@ -101,6 +101,13 @@ static int wl_add(struct acpi_device *device)
if (err) {
pr_err("Failed to setup wireless hotkeys\n");
kfree(button);
return err;
}
err = acpi_dev_install_notify_handler(device, ACPI_DEVICE_NOTIFY,
wl_notify, button);
if (err) {
pr_err("Failed to install ACPI notify handler\n");
wireless_input_destroy(device);
}
return err;
@ -108,6 +115,7 @@ static int wl_add(struct acpi_device *device)
static void wl_remove(struct acpi_device *device)
{
acpi_dev_remove_notify_handler(device, ACPI_DEVICE_NOTIFY, wl_notify);
wireless_input_destroy(device);
}
@ -117,7 +125,6 @@ static struct acpi_driver wl_driver = {
.ops = {
.add = wl_add,
.remove = wl_remove,
.notify = wl_notify,
},
};