github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-12 16:18:45 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

selftests/net: packetdrill: cover RFC 5961 5.2 challenge ACK on both edges

Browse Source 
RFC 5961 Section 5.2 / RFC 793 Section 3.9 require a challenge ACK
whenever an incoming SEG.ACK falls outside
[SND.UNA - MAX.SND.WND, SND.NXT].  There is currently no packetdrill
coverage for either edge.

Add tcp_rfc5961_ack-out-of-window.pkt, which in a single passive-open
connection exercises:

  - Upper edge (SEG.ACK > SND.NXT): peer ACKs data that was never
    sent before the server has transmitted anything.
  - Lower edge (SEG.ACK < SND.UNA - MAX.SND.WND): after the server
    has sent 2000 bytes (the peer-advertised rwnd forces two 1000-byte
    segments, both acknowledged), peer sends an ACK that is older
    than the acceptable window.

Both cases must elicit a challenge ACK
<SEQ = SND.NXT, ACK = RCV.NXT, CTL = ACK>.  The per-socket RFC 5961
Section 7 rate limit is disabled for the duration of the test so that
both challenge ACKs can fire back-to-back.

Signed-off-by: Jiayuan Chen <jiayuan.chen@linux.dev>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20260422123605.320000-3-jiayuan.chen@linux.dev
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Jiayuan Chen 2026-04-22 20:35:39 +08:00 committed by Jakub Kicinski
parent 42726ec644
commit cf94b3c0f0
1 changed files with 48 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
tools/testing/selftests/net/packetdrill/tcp_rfc5961_ack-out-of-window.pkt Normal file
View File

@ -0,0 +1,48 @@
// SPDX-License-Identifier: GPL-2.0
//
// RFC 5961 Section 5.2 / RFC 793 Section 3.9: an incoming segment's
// ACK value must lie in [SND.UNA - MAX.SND.WND, SND.NXT]; otherwise
// the receiver MUST discard the segment and send a challenge ACK
// back. Exercise both edges of that window in a single connection.
`./defaults.sh
sysctl -q net.ipv4.tcp_invalid_ratelimit=0
`
0 socket(..., SOCK_STREAM, IPPROTO_TCP) = 3
+0 setsockopt(3, SOL_SOCKET, SO_REUSEADDR, [1], 4) = 0
+0 bind(3, ..., ...) = 0
+0 listen(3, 1) = 0
// Three-way handshake. Peer advertises rwnd = 1000 (no wscale), so
// MAX.SND.WND is tracked as 1000.
+0 < S 0:0(0) win 1000 <mss 1000,sackOK,nop,nop,nop,wscale 0>
+0 > S. 0:0(0) ack 1 <...>
+.1 < . 1:1(0) ack 1 win 1000
+0 accept(3, ..., ...) = 4
// ---- Upper edge: SEG.ACK > SND.NXT --------------------------------
// Server has sent nothing yet, so SND.UNA = SND.NXT = 1.
// Peer sends a pure ACK with SEG.ACK = 2, beyond SND.NXT.
+0 < . 1:1(0) ack 2 win 1000
// Expect a challenge ACK: <SEQ = SND.NXT = 1, ACK = RCV.NXT = 1>.
+0 > . 1:1(0) ack 1
// Advance SND.UNA past MAX.SND.WND so that the lower edge becomes
// reachable. Issue two 1-MSS writes so each skb is exactly one MSS
// and PSH is set by tcp_push() at the end of each sendmsg, keeping
// the setup independent of the TSO / tcp_fragment split path.
+0 write(4, ..., 1000) = 1000
+0 > P. 1:1001(1000) ack 1
+.01 < . 1:1(0) ack 1001 win 1000
+0 write(4, ..., 1000) = 1000
+0 > P. 1001:2001(1000) ack 1
+.01 < . 1:1(0) ack 2001 win 1000
// Now SND.UNA = SND.NXT = 2001, MAX.SND.WND = 1000, bytes_acked = 2000.
// ---- Lower edge: SEG.ACK < SND.UNA - MAX.SND.WND ------------------
// SND.UNA - MAX.SND.WND = 2001 - 1000 = 1001, so SEG.ACK = 1000 falls
// below the acceptable range.
+0 < . 1:1(0) ack 1000 win 1000
// Expect a challenge ACK: <SEQ = SND.NXT = 2001, ACK = RCV.NXT = 1>.
+0 > . 2001:2001(0) ack 1