github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-22 14:12:07 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

drm/bridge: imx8qxp-pxl2dpi: simplify put of device_node pointers

Browse Source 
Simplify the error-management code in
imx8qxp_pxl2dpi_get_available_ep_from_port() by using a release action for
the struct device_node pointers.

Reviewed-by: Maxime Ripard <mripard@kernel.org>
Link: https://patch.msgid.link/20251216-drm-bridge-alloc-getput-drm_of_find_bridge-v3-13-b5165fab8058@bootlin.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
This commit is contained in:
Luca Ceresoli 2025-12-16 18:58:46 +01:00
parent c87ad784aa
commit ceea3f7806
1 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c
View File

@ -258,35 +258,28 @@ imx8qxp_pxl2dpi_get_available_ep_from_port(struct imx8qxp_pxl2dpi *p2d,
static struct drm_bridge * static struct drm_bridge *
imx8qxp_pxl2dpi_find_next_bridge(struct imx8qxp_pxl2dpi *p2d) imx8qxp_pxl2dpi_find_next_bridge(struct imx8qxp_pxl2dpi *p2d)
{ {
struct device_node *ep, *remote;
struct drm_bridge *next_bridge; struct drm_bridge *next_bridge;
int ret; int ret;
ep = imx8qxp_pxl2dpi_get_available_ep_from_port(p2d, 1); struct device_node *ep __free(device_node) =
imx8qxp_pxl2dpi_get_available_ep_from_port(p2d, 1);
if (IS_ERR(ep)) { if (IS_ERR(ep)) {
ret = PTR_ERR(ep); ret = PTR_ERR(ep);
return ERR_PTR(ret); return ERR_PTR(ret);
} }
remote = of_graph_get_remote_port_parent(ep); struct device_node *remote __free(device_node) = of_graph_get_remote_port_parent(ep);
if (!remote || !of_device_is_available(remote)) { if (!remote || !of_device_is_available(remote)) {
DRM_DEV_ERROR(p2d->dev, "no available remote\n"); DRM_DEV_ERROR(p2d->dev, "no available remote\n");
next_bridge = ERR_PTR(-ENODEV); return ERR_PTR(-ENODEV);
goto out;
} else if (!of_device_is_available(remote->parent)) { } else if (!of_device_is_available(remote->parent)) {
DRM_DEV_ERROR(p2d->dev, "remote parent is not available\n"); DRM_DEV_ERROR(p2d->dev, "remote parent is not available\n");
next_bridge = ERR_PTR(-ENODEV); return ERR_PTR(-ENODEV);
goto out;
} }
next_bridge = of_drm_find_bridge(remote); next_bridge = of_drm_find_bridge(remote);
if (!next_bridge) { if (!next_bridge)
next_bridge = ERR_PTR(-EPROBE_DEFER); return ERR_PTR(-EPROBE_DEFER);
goto out;
}
out:
of_node_put(remote);
of_node_put(ep);
return next_bridge; return next_bridge;
} }