github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-31 10:33:41 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

selftests/bpf: Add F_NEEDS_EFFICIENT_UNALIGNED_ACCESS to some tests

Browse Source 
Some verifier tests were missing F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,
which made the test fail. Add the flag where needed.

Signed-off-by: Björn Töpel <bjorn@rivosinc.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20230705113926.751791-2-bjorn@kernel.org
This commit is contained in:
Björn Töpel 2023-07-05 13:39:25 +02:00 committed by Daniel Borkmann
parent cf6eeb8f9d
commit ce1f289f54
5 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tools/testing/selftests/bpf/verifier/atomic_cmpxchg.c
View File

@ -242,4 +242,5 @@
.result = REJECT, .result = REJECT,
.errstr = "R0 invalid mem access", .errstr = "R0 invalid mem access",
.errstr_unpriv = "R10 partial copy of pointer", .errstr_unpriv = "R10 partial copy of pointer",
.flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,
}, },

2
tools/testing/selftests/bpf/verifier/ctx_skb.c
View File

@ -1169,6 +1169,7 @@
}, },
.result = ACCEPT, .result = ACCEPT,
.prog_type = BPF_PROG_TYPE_SK_SKB, .prog_type = BPF_PROG_TYPE_SK_SKB,
.flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,
}, },
{ {
"pkt_end < pkt taken check", "pkt_end < pkt taken check",
@ -1190,4 +1191,5 @@
}, },
.result = ACCEPT, .result = ACCEPT,
.prog_type = BPF_PROG_TYPE_SK_SKB, .prog_type = BPF_PROG_TYPE_SK_SKB,
.flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,
}, },

8
tools/testing/selftests/bpf/verifier/jmp32.c
View File

@ -290,6 +290,7 @@
.result_unpriv = REJECT, .result_unpriv = REJECT,
.result = ACCEPT, .result = ACCEPT,
.retval = 2, .retval = 2,
.flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,
}, },
{ {
"jgt32: BPF_K", "jgt32: BPF_K",
@ -360,6 +361,7 @@
.result_unpriv = REJECT, .result_unpriv = REJECT,
.result = ACCEPT, .result = ACCEPT,
.retval = 2, .retval = 2,
.flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,
}, },
{ {
"jle32: BPF_K", "jle32: BPF_K",
@ -430,6 +432,7 @@
.result_unpriv = REJECT, .result_unpriv = REJECT,
.result = ACCEPT, .result = ACCEPT,
.retval = 2, .retval = 2,
.flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,
}, },
{ {
"jlt32: BPF_K", "jlt32: BPF_K",
@ -500,6 +503,7 @@
.result_unpriv = REJECT, .result_unpriv = REJECT,
.result = ACCEPT, .result = ACCEPT,
.retval = 2, .retval = 2,
.flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,
}, },
{ {
"jsge32: BPF_K", "jsge32: BPF_K",
@ -570,6 +574,7 @@
.result_unpriv = REJECT, .result_unpriv = REJECT,
.result = ACCEPT, .result = ACCEPT,
.retval = 2, .retval = 2,
.flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,
}, },
{ {
"jsgt32: BPF_K", "jsgt32: BPF_K",
@ -640,6 +645,7 @@
.result_unpriv = REJECT, .result_unpriv = REJECT,
.result = ACCEPT, .result = ACCEPT,
.retval = 2, .retval = 2,
.flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,
}, },
{ {
"jsle32: BPF_K", "jsle32: BPF_K",
@ -710,6 +716,7 @@
.result_unpriv = REJECT, .result_unpriv = REJECT,
.result = ACCEPT, .result = ACCEPT,
.retval = 2, .retval = 2,
.flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,
}, },
{ {
"jslt32: BPF_K", "jslt32: BPF_K",
@ -780,6 +787,7 @@
.result_unpriv = REJECT, .result_unpriv = REJECT,
.result = ACCEPT, .result = ACCEPT,
.retval = 2, .retval = 2,
.flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,
}, },
{ {
"jgt32: range bound deduction, reg op imm", "jgt32: range bound deduction, reg op imm",

2
tools/testing/selftests/bpf/verifier/map_kptr.c
View File

@ -68,6 +68,7 @@
.fixup_map_kptr = { 1 }, .fixup_map_kptr = { 1 },
.result = REJECT, .result = REJECT,
.errstr = "kptr access cannot have variable offset", .errstr = "kptr access cannot have variable offset",
.flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,
}, },
{ {
"map_kptr: bpf_kptr_xchg non-const var_off", "map_kptr: bpf_kptr_xchg non-const var_off",
@ -121,6 +122,7 @@
.fixup_map_kptr = { 1 }, .fixup_map_kptr = { 1 },
.result = REJECT, .result = REJECT,
.errstr = "kptr access misaligned expected=0 off=7", .errstr = "kptr access misaligned expected=0 off=7",
.flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,
}, },
{ {
"map_kptr: reject var_off != 0", "map_kptr: reject var_off != 0",

2
tools/testing/selftests/bpf/verifier/precise.c
View File

@ -216,7 +216,7 @@
}, },
.fixup_map_ringbuf = { 1 }, .fixup_map_ringbuf = { 1 },
.prog_type = BPF_PROG_TYPE_XDP, .prog_type = BPF_PROG_TYPE_XDP,
.flags = BPF_F_TEST_STATE_FREQ, .flags = BPF_F_TEST_STATE_FREQ | F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,
.errstr = "invalid access to memory, mem_size=1 off=42 size=8", .errstr = "invalid access to memory, mem_size=1 off=42 size=8",
.result = REJECT, .result = REJECT,
}, },