f2fs: fix to fetch ino via ino_of_node() under cache lock

In f2fs_writeback_node_caches(), it's better to fetch ino via ino_of_node()
under cache lock, otherwise, node cache content may become stale after cache
is unlocked due to racing w/ truncation.

Commit 493b9dc8b5 ("f2fs: cache: use node cache") fixes similar issue in
f2fs_flush_inline_data() introduced in commit 34c061ad85 ("f2fs: Avoid double
lock for cp_rwsem during checkpoint").

Cc: stable@kernel.org
Fixes: 2049d4fcb0 ("f2fs: avoid multiple node page writes due to inline_data")
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
This commit is contained in:
Chao Yu 2026-10-26 08:23:49 +08:00 committed by Jaegeuk Kim
parent fd106ada4d
commit cd6d8b1891

View File

@ -2195,9 +2195,11 @@ int f2fs_writeback_node_caches(struct f2fs_sb_info *sbi, long nr_to_write,
/* flush inline_data */
if (f2fs_cache_test_inline(entry)) {
nid_t ino = ino_of_node(sbi, entry);
f2fs_cache_clear_inline(entry);
f2fs_unlock_cache(entry);
flush_inline_data(sbi, ino_of_node(sbi, entry));
flush_inline_data(sbi, ino);
goto lock_node;
}