github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-24 06:24:02 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

soundwire: stream: validate slave port properties

Browse Source 
sdw_slave_port_config() validates that a port number is within the
generic valid range, but does not verify that the Slave exposes the
port for the requested stream direction. As a result, an in-range but
unsupported port, or a valid port used in the wrong direction, can be
accepted.

Use sdw_get_slave_dpn_prop() to perform the direction-specific lookup
and reject unsupported ports before storing the runtime configuration.

Signed-off-by: Eric Wu <kunjinkao.jp@gmail.com>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://patch.msgid.link/20260731123415.34070-1-kunjinkao.jp@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Eric Wu 2026-07-31 20:34:15 +08:00 committed by Vinod Koul
parent b3d2703946
commit cd4a294c4b
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
drivers/soundwire/stream.c
View File

@ -1061,14 +1061,23 @@ static int sdw_slave_port_config(struct sdw_slave *slave,
i = 0;
list_for_each_entry(p_rt, &s_rt->port_list, port_node) {
/*
* TODO: Check valid port range as defined by DisCo/
* slave
*/
if (!is_bpt_stream) {
ret = sdw_slave_port_is_valid_range(&slave->dev, port_config[i].num);
if (ret < 0)
return ret;
/*
* A port in the generic valid range may still be unsupported by
* the Slave or unavailable for the requested stream direction.
*/
if (!sdw_get_slave_dpn_prop(slave, s_rt->direction,
port_config[i].num)) {
dev_err(&slave->dev,
"port %u not supported for %s\n",
port_config[i].num,
s_rt->direction == SDW_DATA_DIR_TX ? "TX" : "RX");
return -EINVAL;
}
} else if (port_config[i].num) {
return -EINVAL;
}