mirror of
https://github.com/torvalds/linux.git
synced 2026-09-24 06:24:02 +02:00
ASoC: fsl_esai: Use guard() for spin locks
Clean up the code using guard() for spin locks. Merely code refactoring, and no behavior change. Signed-off-by: bui duc phuc <phucduc.bui@gmail.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> Link: https://patch.msgid.link/20260615093824.115751-5-phucduc.bui@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
parent
48d84310be
commit
cb87bdabd3
|
|
@ -709,10 +709,9 @@ static void fsl_esai_hw_reset(struct work_struct *work)
|
|||
{
|
||||
struct fsl_esai *esai_priv = container_of(work, struct fsl_esai, work);
|
||||
bool tx = true, rx = false, enabled[2];
|
||||
unsigned long lock_flags;
|
||||
u32 tfcr, rfcr;
|
||||
|
||||
spin_lock_irqsave(&esai_priv->lock, lock_flags);
|
||||
guard(spinlock_irqsave)(&esai_priv->lock);
|
||||
/* Save the registers */
|
||||
regmap_read(esai_priv->regmap, REG_ESAI_TFCR, &tfcr);
|
||||
regmap_read(esai_priv->regmap, REG_ESAI_RFCR, &rfcr);
|
||||
|
|
@ -750,8 +749,6 @@ static void fsl_esai_hw_reset(struct work_struct *work)
|
|||
fsl_esai_trigger_start(esai_priv, tx);
|
||||
if (enabled[rx])
|
||||
fsl_esai_trigger_start(esai_priv, rx);
|
||||
|
||||
spin_unlock_irqrestore(&esai_priv->lock, lock_flags);
|
||||
}
|
||||
|
||||
static int fsl_esai_trigger(struct snd_pcm_substream *substream, int cmd,
|
||||
|
|
@ -759,7 +756,6 @@ static int fsl_esai_trigger(struct snd_pcm_substream *substream, int cmd,
|
|||
{
|
||||
struct fsl_esai *esai_priv = snd_soc_dai_get_drvdata(dai);
|
||||
bool tx = substream->stream == SNDRV_PCM_STREAM_PLAYBACK;
|
||||
unsigned long lock_flags;
|
||||
|
||||
esai_priv->channels[tx] = substream->runtime->channels;
|
||||
|
||||
|
|
@ -767,16 +763,14 @@ static int fsl_esai_trigger(struct snd_pcm_substream *substream, int cmd,
|
|||
case SNDRV_PCM_TRIGGER_START:
|
||||
case SNDRV_PCM_TRIGGER_RESUME:
|
||||
case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
|
||||
spin_lock_irqsave(&esai_priv->lock, lock_flags);
|
||||
fsl_esai_trigger_start(esai_priv, tx);
|
||||
spin_unlock_irqrestore(&esai_priv->lock, lock_flags);
|
||||
scoped_guard(spinlock_irqsave, &esai_priv->lock)
|
||||
fsl_esai_trigger_start(esai_priv, tx);
|
||||
break;
|
||||
case SNDRV_PCM_TRIGGER_SUSPEND:
|
||||
case SNDRV_PCM_TRIGGER_STOP:
|
||||
case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
|
||||
spin_lock_irqsave(&esai_priv->lock, lock_flags);
|
||||
fsl_esai_trigger_stop(esai_priv, tx);
|
||||
spin_unlock_irqrestore(&esai_priv->lock, lock_flags);
|
||||
scoped_guard(spinlock_irqsave, &esai_priv->lock)
|
||||
fsl_esai_trigger_stop(esai_priv, tx);
|
||||
break;
|
||||
default:
|
||||
return -EINVAL;
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user