github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-26 16:12:59 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

media: synopsys: hdmirx: Fix signedness bug in hdmirx_parse_dt()

Browse Source 
The num_clks is set this way:

	hdmirx_dev->num_clks = devm_clk_bulk_get_all(dev, &hdmirx_dev->clks);
        if (hdmirx_dev->num_clks < 1)
                return -ENODEV;

The devm_clk_bulk_get_all() function returns negative error codes so the
hdmirx_dev->num_cks variable needs to be signed for the error handling to
work.

Fixes: 7b59b132ad ("media: platform: synopsys: Add support for HDMI input driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
This commit is contained in:
Dan Carpenter 2025-03-07 12:30:16 +03:00 committed by Hans Verkuil
parent fae8cab4ba
commit ca8dc5951b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
View File

@ -151,7 +151,7 @@ struct snps_hdmirx_dev {
bool hpd_trigger_level_high;
bool tmds_clk_ratio;
bool plugged;
u32 num_clks;
int num_clks;
u32 edid_blocks_written;
u32 cur_fmt_fourcc;
u32 color_depth;