github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-07 05:55:44 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

f2fs: initialize page->private when using for our internal use

Browse Source 
We need to guarantee it's initially zero. Otherwise, it'll hurt entire flag
operations.

Fixes: b763f3bedc ("f2fs: restructure f2fs page.private layout")
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
This commit is contained in:
Jaegeuk Kim 2021-07-04 22:11:25 -07:00
parent 151b1982be
commit c9ebd3df43
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/f2fs/data.c
View File

@ -3819,6 +3819,8 @@ int f2fs_migrate_page(struct address_space *mapping,
get_page(newpage); get_page(newpage);
} }
/* guarantee to start from no stale private field */
set_page_private(newpage, 0);
if (PagePrivate(page)) { if (PagePrivate(page)) {
set_page_private(newpage, page_private(page)); set_page_private(newpage, page_private(page));
SetPagePrivate(newpage); SetPagePrivate(newpage);

5
fs/f2fs/f2fs.h
View File

@ -1331,7 +1331,8 @@ enum {
#define PAGE_PRIVATE_GET_FUNC(name, flagname) \ #define PAGE_PRIVATE_GET_FUNC(name, flagname) \
static inline bool page_private_##name(struct page *page) \ static inline bool page_private_##name(struct page *page) \
{ \ { \
return test_bit(PAGE_PRIVATE_NOT_POINTER, &page_private(page)) && \ return PagePrivate(page) && \
test_bit(PAGE_PRIVATE_NOT_POINTER, &page_private(page)) && \
test_bit(PAGE_PRIVATE_##flagname, &page_private(page)); \ test_bit(PAGE_PRIVATE_##flagname, &page_private(page)); \
} }
@ -1341,6 +1342,7 @@ static inline void set_page_private_##name(struct page *page) \
if (!PagePrivate(page)) { \ if (!PagePrivate(page)) { \
get_page(page); \ get_page(page); \
SetPagePrivate(page); \ SetPagePrivate(page); \
set_page_private(page, 0); \
} \ } \
set_bit(PAGE_PRIVATE_NOT_POINTER, &page_private(page)); \ set_bit(PAGE_PRIVATE_NOT_POINTER, &page_private(page)); \
set_bit(PAGE_PRIVATE_##flagname, &page_private(page)); \ set_bit(PAGE_PRIVATE_##flagname, &page_private(page)); \
@ -1392,6 +1394,7 @@ static inline void set_page_private_data(struct page *page, unsigned long data)
if (!PagePrivate(page)) { if (!PagePrivate(page)) {
get_page(page); get_page(page);
SetPagePrivate(page); SetPagePrivate(page);
set_page_private(page, 0);
} }
set_bit(PAGE_PRIVATE_NOT_POINTER, &page_private(page)); set_bit(PAGE_PRIVATE_NOT_POINTER, &page_private(page));
page_private(page) |= data << PAGE_PRIVATE_MAX; page_private(page) |= data << PAGE_PRIVATE_MAX;