github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-07 06:17:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

selftests/seccomp: test addfd with an O_PATH descriptor

Browse Source 
SECCOMP_IOCTL_NOTIF_ADDFD used to reject O_PATH source descriptors with
EBADF. Add a regression test that injects one into a notified task.

Verify that the injected descriptor retains O_PATH semantics and the
requested close-on-exec flag. The test fails on the original fget()
path and passes with fget_raw().

Assisted-by: Codex:gpt-6
Signed-off-by: Cong Wang <cwang@multikernel.io>
Link: https://patch.msgid.link/20260924223018.564548-3-xiyou.wangcong@gmail.com
Signed-off-by: Kees Cook <kees@kernel.org>
This commit is contained in:
Cong Wang 2026-09-24 15:30:17 -07:00 committed by Kees Cook
parent 54971c8061
commit c96a4cb2c8
1 changed files with 59 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

59
tools/testing/selftests/seccomp/seccomp_bpf.c
View File

@ -4302,6 +4302,65 @@ TEST(user_notification_addfd)
close(memfd);
}
TEST(user_notification_addfd_opath)
{
struct seccomp_notif req = {};
struct seccomp_notif_addfd addfd = {};
struct seccomp_notif_resp resp = {};
pid_t pid;
int listener, pathfd, fd, status;
pathfd = open("/dev/null", O_PATH | O_CLOEXEC);
ASSERT_GE(pathfd, 0);
ASSERT_EQ(prctl(PR_SET_NO_NEW_PRIVS, 1, 0, 0, 0), 0);
listener = user_notif_syscall(__NR_getppid,
SECCOMP_FILTER_FLAG_NEW_LISTENER);
ASSERT_GE(listener, 0);
pid = fork();
ASSERT_GE(pid, 0);
if (pid == 0) {
int flags;
char byte;
close(pathfd);
fd = syscall(__NR_getppid);
if (fd < 0)
_exit(1);
flags = fcntl(fd, F_GETFL);
if (flags < 0 || !(flags & O_PATH))
_exit(2);
flags = fcntl(fd, F_GETFD);
if (flags < 0 || !(flags & FD_CLOEXEC))
_exit(3);
errno = 0;
if (read(fd, &byte, 1) != -1 || errno != EBADF)
_exit(4);
_exit(0);
}
ASSERT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_RECV, &req), 0);
addfd.id = req.id;
addfd.flags = SECCOMP_ADDFD_FLAG_SEND;
addfd.srcfd = pathfd;
addfd.newfd_flags = O_CLOEXEC;
fd = ioctl(listener, SECCOMP_IOCTL_NOTIF_ADDFD, &addfd);
if (fd < 0) {
resp.id = req.id;
resp.error = -errno;
TH_LOG("ADDFD failed with errno %d", -resp.error);
ASSERT_EQ(ioctl(listener, SECCOMP_IOCTL_NOTIF_SEND, &resp), 0);
}
ASSERT_EQ(waitpid(pid, &status, 0), pid);
EXPECT_GE(fd, 0);
EXPECT_EQ(true, WIFEXITED(status));
if (WIFEXITED(status))
EXPECT_EQ(0, WEXITSTATUS(status));
close(pathfd);
close(listener);
}
TEST(user_notification_addfd_rlimit)
{
pid_t pid;