github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-28 01:55:51 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

powerpc/pseries/lparcfg: Replace deprecated strcpy in parse_system_parameter_string

Browse Source 
strcpy() is deprecated; use strscpy() instead. Use the return value of
strscpy() instead of calling strlen() again, and ignore any potential
string truncation since both strings are much shorter than the buffer
size SPLPAR_MAXLENGTH.

Change both if conditions to silence the following checkpatch warnings:

  Comparisons should place the constant on the right side of the test

Link: https://github.com/KSPP/linux/issues/88
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20251013135703.97260-2-thorsten.blum@linux.dev
This commit is contained in:
Thorsten Blum 2025-10-13 15:57:02 +02:00 committed by Madhavan Srinivasan
parent 457cf3d00d
commit c8f80f95da
1 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
arch/powerpc/platforms/pseries/lparcfg.c
View File

@ -22,6 +22,7 @@
#include <asm/papr-sysparm.h>
#include <linux/seq_file.h>
#include <linux/slab.h>
#include <linux/string.h>
#include <linux/uaccess.h>
#include <linux/hugetlb.h>
#include <asm/lppaca.h>
@ -431,17 +432,18 @@ static void parse_system_parameter_string(struct seq_file *m)
w_idx = 0;
} else if (local_buffer[idx] == '=') {
/* code here to replace workbuffer contents
with different keyword strings */
if (0 == strcmp(workbuffer, "MaxEntCap")) {
strcpy(workbuffer,
"partition_max_entitled_capacity");
w_idx = strlen(workbuffer);
}
if (0 == strcmp(workbuffer, "MaxPlatProcs")) {
strcpy(workbuffer,
"system_potential_processors");
w_idx = strlen(workbuffer);
}
* with different keyword strings. Truncation
* by strscpy is deliberately ignored because
* SPLPAR_MAXLENGTH >= maximum string size.
*/
if (!strcmp(workbuffer, "MaxEntCap"))
w_idx = strscpy(workbuffer,
"partition_max_entitled_capacity",
SPLPAR_MAXLENGTH);
if (!strcmp(workbuffer, "MaxPlatProcs"))
w_idx = strscpy(workbuffer,
"system_potential_processors",
SPLPAR_MAXLENGTH);
}
}
kfree(workbuffer);