github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-22 20:54:03 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

can: tcan4x5x: put tcan into sleep when removing driver

Browse Source 
Put the tcan4x5x transceiver into sleep mode when the driver is
removed, instead of leaving it in its current operating mode.
This reduces power consumption(3mA@12V) once the driver is
no longer bound to the device.

Signed-off-by: Sean Nyekjaer <sean@geanix.com>
Link: https://patch.msgid.link/20260805110708.3220251-1-sean@geanix.com
[mkl: tcan4x5x_power_enable(): reduce scope of ret]
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
This commit is contained in:
Sean Nyekjaer 2026-08-05 13:07:07 +02:00 committed by Marc Kleine-Budde
parent e6a5d573d2
commit c7d2577bf1
1 changed files with 27 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
drivers/net/can/m_can/tcan4x5x-core.c
View File

@ -211,8 +211,31 @@ static int tcan4x5x_write_fifo(struct m_can_classdev *cdev,
return regmap_bulk_write(priv->regmap, TCAN4X5X_MRAM_START + addr_offset, val, val_count);
}
static int tcan4x5x_power_enable(struct regulator *reg, int enable)
static int tcan4x5x_power_enable(struct tcan4x5x_priv *priv, int enable)
{
struct regulator *reg = priv->power;
/*
* Put the device into sleep mode if the RST pin is available,
* since a wake-up event, RST pin toggle, or power cycle are the only
* ways to exit sleep mode.
* Redundant if the regulator is exclusive to this device, but that
* can't be determined here.
*
* Datasheet: TCAN4550, section "8.4.3 Sleep Mode"
* https://www.ti.com/lit/gpn/tcan4550
*/
if (priv->reset_gpio && !enable) {
int ret;
ret = regmap_update_bits(priv->regmap, TCAN4X5X_CONFIG,
TCAN4X5X_MODE_SEL_MASK,
TCAN4X5X_MODE_SLEEP);
if (ret)
dev_err(&priv->spi->dev, "Setting sleep mode failed %pe\n",
ERR_PTR(ret));
}
if (IS_ERR_OR_NULL(reg))
return 0;
@ -476,7 +499,7 @@ static int tcan4x5x_can_probe(struct spi_device *spi)
goto out_m_can_class_free_dev;
}
ret = tcan4x5x_power_enable(priv->power, 1);
ret = tcan4x5x_power_enable(priv, 1);
if (ret) {
dev_err(&spi->dev, "Enabling regulator failed %pe\n",
ERR_PTR(ret));
@ -531,7 +554,7 @@ static int tcan4x5x_can_probe(struct spi_device *spi)
return 0;
out_power:
tcan4x5x_power_enable(priv->power, 0);
tcan4x5x_power_enable(priv, 0);
out_m_can_class_free_dev:
m_can_class_free_dev(mcan_class->net);
return ret;
@ -543,7 +566,7 @@ static void tcan4x5x_can_remove(struct spi_device *spi)
m_can_class_unregister(&priv->cdev);
tcan4x5x_power_enable(priv->power, 0);
tcan4x5x_power_enable(priv, 0);
m_can_class_free_dev(priv->cdev.net);
}