From c64c793d9a162768a78f98f99774b5df6d360d0b Mon Sep 17 00:00:00 2001 From: Gary Guo Date: Tue, 28 Apr 2026 14:10:55 +0100 Subject: [PATCH] rust: pin-init: internal: remove redundant `#[pin]` filtering The `generate_projections` and `generate_the_pin_data` function already receive filtered field lists, they do not need to filter out `#[pin]` again. Reviewed-by: Benno Lossin Link: https://patch.msgid.link/20260428-pin-init-sync-v1-6-07f9bd3859fb@garyguo.net Signed-off-by: Gary Guo --- rust/pin-init/internal/src/pin_data.rs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/rust/pin-init/internal/src/pin_data.rs b/rust/pin-init/internal/src/pin_data.rs index 6b1b8f26379a..76cd11bf28eb 100644 --- a/rust/pin-init/internal/src/pin_data.rs +++ b/rust/pin-init/internal/src/pin_data.rs @@ -258,8 +258,6 @@ fn generate_projections( .. }, )| { - let mut attrs = attrs.clone(); - attrs.retain(|a| !a.path().is_ident("pin")); let mut no_doc_attrs = attrs.clone(); no_doc_attrs.retain(|a| !a.path().is_ident("doc")); let ident = ident @@ -360,8 +358,6 @@ fn handle_field( struct_ident: &Ident, pinned: bool, ) -> TokenStream { - let mut attrs = attrs.clone(); - attrs.retain(|a| !a.path().is_ident("pin")); let ident = ident .as_ref() .expect("only structs with named fields are supported");