github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-23 06:31:58 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

platform/x86: oxpec: Add a lower bounds check in oxp_psy_ext_set_prop()

Browse Source 
The "val->intval" variable is an integer which comes from the user.  This
code has an upper bounds check but the lower bounds check was
accidentally omitted.  The write_to_ec() take a u8 value as a parameter
so negative values would be truncated to positive values in the 0-255
range.

Return -EINVAL if the user passes a negative value.

Fixes: 202593d1e86b ("platform/x86: oxpec: Add charge threshold and behaviour to OneXPlayer")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Antheas Kapenekakis <lkml@antheas.dev>
Link: https://lore.kernel.org/r/aBSE71VKfBlQg_fZ@stanley.mountain
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
This commit is contained in:
Dan Carpenter 2025-05-02 11:40:15 +03:00 committed by Ilpo Järvinen
parent a59211ee46
commit c5925f4384
No known key found for this signature in database
GPG Key ID: 59AC4F6153E5CE31
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/platform/x86/oxpec.c
View File

@ -582,7 +582,7 @@ static int oxp_psy_ext_set_prop(struct power_supply *psy,
switch (psp) {
case POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD:
if (val->intval > 100)
if (val->intval < 0 || val->intval > 100)
return -EINVAL;
return write_to_ec(OXP_X1_CHARGE_LIMIT_REG, val->intval);
case POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR: