From c39a9a02bc5d841c116dc03c264eb9ceecde806e Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Mon, 1 Jun 2026 23:02:04 +0200 Subject: [PATCH] scsi: megaraid_mbox: Avoid double kfree() Smatch found a double-free after my recent change: drivers/scsi/megaraid/megaraid_mbox.c:3474 megaraid_cmm_register() error: double free of 'adp' (line 3468) Since the object is no longer allocated in megaraid_cmm_register(), remove the kfree() as well. Fixes: c1f7275b613b ("scsi: megaraid_mbox: Reduce stack usage in megaraid_cmm_register()") Reported-by: Dan Carpenter Signed-off-by: Arnd Bergmann Link: https://patch.msgid.link/20260601210216.846809-1-arnd@kernel.org Signed-off-by: Martin K. Petersen --- drivers/scsi/megaraid/megaraid_mm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_mm.c b/drivers/scsi/megaraid/megaraid_mm.c index 60db48dc8f3a..e572665903d2 100644 --- a/drivers/scsi/megaraid/megaraid_mm.c +++ b/drivers/scsi/megaraid/megaraid_mm.c @@ -998,8 +998,6 @@ mraid_mm_register_adp(mraid_mmadp_t *adapter) dma_pool_destroy(adapter->pthru_dma_pool); - kfree(adapter); - return rval; }