github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-06 13:37:36 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

video: fbdev: clcdfb: Fix refcount leak in clcdfb_of_vram_setup

Browse Source 
[ Upstream commit b23789a59f ]

of_parse_phandle() returns a node pointer with refcount incremented, we should
use of_node_put() on it when not need anymore.  Add missing of_node_put() to
avoid refcount leak.

Fixes: d10715be03 ("video: ARM CLCD: Add DT support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Miaoqian Lin 2022-05-12 15:59:08 +04:00 committed by Greg Kroah-Hartman
parent 96fdbb1c85
commit c1c4405222
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/video/fbdev/amba-clcd.c
View File

@ -771,12 +771,15 @@ static int clcdfb_of_vram_setup(struct clcd_fb *fb)
return -ENODEV; return -ENODEV;
fb->fb.screen_base = of_iomap(memory, 0); fb->fb.screen_base = of_iomap(memory, 0);
if (!fb->fb.screen_base) if (!fb->fb.screen_base) {
of_node_put(memory);
return -ENOMEM; return -ENOMEM;
}
fb->fb.fix.smem_start = of_translate_address(memory, fb->fb.fix.smem_start = of_translate_address(memory,
of_get_address(memory, 0, &size, NULL)); of_get_address(memory, 0, &size, NULL));
fb->fb.fix.smem_len = size; fb->fb.fix.smem_len = size;
of_node_put(memory);
return 0; return 0;
} }