mirror of
https://github.com/torvalds/linux.git
synced 2026-07-27 01:32:21 +02:00
thunderbolt: debugfs: Fix sideband write size check
sb_regs_write() looks up the matching sideband register entry before validating the number of bytes to write. However, the size check uses sb_regs->size, which is the size of the first entry in the register table, instead of the matched entry. This rejects valid writes to larger sideband registers such as USB4_SB_DEBUG or USB4_SB_DATA. Use the matched register entry for the size check. Signed-off-by: Xu Rao <raoxu@uniontech.com> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
This commit is contained in:
parent
503c5ae1e7
commit
c1bef05763
|
|
@ -366,7 +366,7 @@ static ssize_t sb_regs_write(struct tb_port *port, const struct sb_reg *sb_regs,
|
|||
if (!sb_reg)
|
||||
return -EINVAL;
|
||||
|
||||
if (bytes_read > sb_regs->size)
|
||||
if (bytes_read > sb_reg->size)
|
||||
return -E2BIG;
|
||||
|
||||
ret = usb4_port_sb_write(port, target, index, sb_reg->reg, data,
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user