github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-29 02:31:27 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

smb: client: Use more common error handling code in smb3_reconfigure()

Browse Source 
Use an additional label so that a bit of exception handling can be better
reused at the end of this function implementation.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Steve French <stfrench@microsoft.com>
This commit is contained in:
Markus Elfring 2026-06-11 17:33:39 +02:00 committed by Steve French
parent 61f28012e5
commit c1266041e6
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
fs/smb/client/fs_context.c
View File

@ -1092,10 +1092,8 @@ static int smb3_reconfigure(struct fs_context *fc)
return -ENOMEM;
rc = smb3_fs_context_dup(old_ctx, cifs_sb->ctx);
if (rc) {
kfree(old_ctx);
return rc;
}
if (rc)
goto free_old_ctx;
/*
* We can not change UNC/username/password/domainname/
@ -1244,6 +1242,7 @@ static int smb3_reconfigure(struct fs_context *fc)
kfree_sensitive(new_password2);
smb3_cleanup_fs_context_contents(cifs_sb->ctx);
memcpy(cifs_sb->ctx, old_ctx, sizeof(*old_ctx));
free_old_ctx:
kfree(old_ctx);
return rc;