github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-07 06:17:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

net: mctp: usblib: Add tests of invalid headers

Browse Source 
Add tests where the length field of the USB transport header is below
the minimum value, and where the DMTF ID is invalid.

Signed-off-by: James Lee <james@codeconstruct.com.au>
Link: https://patch.msgid.link/20261014-dev-mctp-usb-lib-test-v3-3-ee5bc3ea1db1@codeconstruct.com.au
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
James Lee 2026-10-14 12:47:33 +08:00 committed by Jakub Kicinski
parent 21e1d45157
commit c0a372f729
1 changed files with 68 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

68
drivers/net/mctp/mctp-usblib-test.c
View File

@ -461,11 +461,79 @@ static void mctp_usblib_test_rx_header_splits(struct kunit *test)
mctp_usblib_test_rx_split_header(test, 8, dev, rx);
}
/* Test the submission of a packet with an impossibly small value in the
* header's length field. Values less than HDR_LEN are invalid.
*/
static void mctp_usblib_test_rx_short_packet(struct kunit *test)
{
struct mctp_usblib_test_dev *dev;
struct mctp_usblib_test_ctx *ctx;
struct mctp_usblib_rx *rx;
size_t len, buflen;
u8 pktbuf[12];
void *buf;
int rc;
ctx = mctp_usblib_test_init(test);
rx = mctp_usblib_test_rx_init(test, true);
dev = ctx->dev;
len = sizeof(pktbuf);
mctp_usblib_test_init_pkt(pktbuf, len, HDR_LEN - 1);
buflen = 0;
rc = mctp_usblib_rx_prepare(dev->ndev, rx, &buf, &buflen, GFP_KERNEL);
KUNIT_ASSERT_EQ(test, rc, 0);
KUNIT_ASSERT_GE(test, buflen, len);
memcpy(buf, pktbuf, len);
rc = mctp_usblib_rx_complete(dev->ndev, rx, len);
KUNIT_EXPECT_EQ(test, rc, -EPROTO);
KUNIT_EXPECT_NULL(test, rx->skb);
KUNIT_EXPECT_EQ(test, dev->rx_pkts.qlen, 0);
}
static void mctp_usblib_test_rx_invalid_dmtf_id(struct kunit *test)
{
struct mctp_usblib_test_dev *dev;
struct mctp_usblib_test_ctx *ctx;
struct mctp_usblib_rx *rx;
size_t len, buflen;
u8 pktbuf[12];
void *buf;
int rc;
ctx = mctp_usblib_test_init(test);
rx = mctp_usblib_test_rx_init(test, true);
dev = ctx->dev;
len = sizeof(pktbuf);
mctp_usblib_test_init_pkt(pktbuf, len, len);
/* Make packet DMTF ID invalid */
pktbuf[1] = ~pktbuf[1];
buflen = 0;
rc = mctp_usblib_rx_prepare(dev->ndev, rx, &buf, &buflen, GFP_KERNEL);
KUNIT_ASSERT_EQ(test, rc, 0);
KUNIT_ASSERT_GE(test, buflen, len);
memcpy(buf, pktbuf, len);
rc = mctp_usblib_rx_complete(dev->ndev, rx, len);
KUNIT_EXPECT_EQ(test, rc, -EPROTO);
KUNIT_EXPECT_NULL(test, rx->skb);
KUNIT_EXPECT_EQ(test, dev->rx_pkts.qlen, 0);
}
static struct kunit_case mctp_usblib_test_cases[] = {
KUNIT_CASE(mctp_usblib_test_rx_single),
KUNIT_CASE_PARAM(mctp_usblib_test_rx_pkt_span,
mctp_usblib_test_rx_pkt_span_gen_params),
KUNIT_CASE(mctp_usblib_test_rx_header_splits),
KUNIT_CASE(mctp_usblib_test_rx_short_packet),
KUNIT_CASE(mctp_usblib_test_rx_invalid_dmtf_id),
{}
};