github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-13 00:28:54 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

rtla: Fix segfault on multiple SIGINTs

Browse Source 
Detach stop_trace() from SIGINT/SIGALRM on tool clean-up to prevent it
from crashing RTLA by accessing freed memory.

This prevents a crash when multiple SIGINTs are received.

Fixes: d6899e5603 ("rtla/timerlat_hist: Abort event processing on second signal")
Fixes: 80967b354a ("rtla/timerlat_top: Abort event processing on second signal")
Reviewed-by: Wander Lairson Costa <wander@redhat.com>
Link: https://lore.kernel.org/r/20260310160725.144443-1-tglozar@redhat.com
Signed-off-by: Tomas Glozar <tglozar@redhat.com>
This commit is contained in:
Tomas Glozar 2026-03-10 17:07:25 +01:00
parent 99261ccdc0
commit be8058f31b
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tools/tracing/rtla/src/common.c
View File

@ -41,6 +41,18 @@ static void set_signals(struct common_params *params)
}
}
/*
* unset_signals - unsets the signals to stop the tool
*/
static void unset_signals(struct common_params *params)
{
signal(SIGINT, SIG_DFL);
if (params->duration) {
alarm(0);
signal(SIGALRM, SIG_DFL);
}
}
/*
* getopt_auto - auto-generates optstring from long_options
*/
@ -351,7 +363,7 @@ int run_tool(struct tool_ops *ops, int argc, char *argv[])
retval = ops->main(tool);
if (retval)
goto out_trace;
goto out_signals;
if (params->user_workload && !params->user.stopped_running) {
params->user.should_run = 0;
@ -373,6 +385,8 @@ int run_tool(struct tool_ops *ops, int argc, char *argv[])
if (ops->analyze)
ops->analyze(tool, stopped);
out_signals:
unset_signals(params);
out_trace:
trace_events_destroy(&tool->record->trace, params->events);
params->events = NULL;