mirror of
https://github.com/torvalds/linux.git
synced 2026-05-30 18:13:41 +02:00
w1: ds2430: Constify 'struct bin_attribute'
The sysfs core now allows instances of 'struct bin_attribute' to be moved into read-only memory. Make use of that to protect them against accidental or malicious modifications. Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> Link: https://lore.kernel.org/r/20241211-sysfs-const-bin_attr-w1-v1-5-c4befd2aa7cc@weissschuh.net Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
This commit is contained in:
parent
f597a4ce8c
commit
be0d277fd3
|
|
@ -95,7 +95,7 @@ static int w1_f14_readblock(struct w1_slave *sl, int off, int count, char *buf)
|
|||
}
|
||||
|
||||
static ssize_t eeprom_read(struct file *filp, struct kobject *kobj,
|
||||
struct bin_attribute *bin_attr, char *buf,
|
||||
const struct bin_attribute *bin_attr, char *buf,
|
||||
loff_t off, size_t count)
|
||||
{
|
||||
struct w1_slave *sl = kobj_to_w1_slave(kobj);
|
||||
|
|
@ -202,7 +202,7 @@ static int w1_f14_write(struct w1_slave *sl, int addr, int len, const u8 *data)
|
|||
}
|
||||
|
||||
static ssize_t eeprom_write(struct file *filp, struct kobject *kobj,
|
||||
struct bin_attribute *bin_attr, char *buf,
|
||||
const struct bin_attribute *bin_attr, char *buf,
|
||||
loff_t off, size_t count)
|
||||
{
|
||||
struct w1_slave *sl = kobj_to_w1_slave(kobj);
|
||||
|
|
@ -263,15 +263,15 @@ static ssize_t eeprom_write(struct file *filp, struct kobject *kobj,
|
|||
return count;
|
||||
}
|
||||
|
||||
static BIN_ATTR_RW(eeprom, W1_F14_EEPROM_SIZE);
|
||||
static const BIN_ATTR_RW(eeprom, W1_F14_EEPROM_SIZE);
|
||||
|
||||
static struct bin_attribute *w1_f14_bin_attrs[] = {
|
||||
static const struct bin_attribute *const w1_f14_bin_attrs[] = {
|
||||
&bin_attr_eeprom,
|
||||
NULL,
|
||||
};
|
||||
|
||||
static const struct attribute_group w1_f14_group = {
|
||||
.bin_attrs = w1_f14_bin_attrs,
|
||||
.bin_attrs_new = w1_f14_bin_attrs,
|
||||
};
|
||||
|
||||
static const struct attribute_group *w1_f14_groups[] = {
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user