github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-10-14 11:54:03 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

staging: pi433: Remove duplicated code using the "goto" error recovery scheme.

Browse Source 
pi433_init had "unregister_chrdev" called twice.
Remove it using goto statements.

Signed-off-by: Shahar Avidar <ikobh7@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20240405074000.3481217-6-ikobh7@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Shahar Avidar 2024-04-05 10:39:58 +03:00 committed by Greg Kroah-Hartman
parent 494566f7a5
commit bd9ea55b22
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/staging/pi433/pi433_if.c
View File

@ -1401,21 +1401,21 @@ static int __init pi433_init(void)
return status;
status = class_register(&pi433_class);
if (status) {
unregister_chrdev(MAJOR(pi433_devt),
pi433_spi_driver.driver.name);
return status;
}
if (status)
goto unreg_chrdev;
root_dir = debugfs_create_dir(KBUILD_MODNAME, NULL);
status = spi_register_driver(&pi433_spi_driver);
if (status < 0) {
class_unregister(&pi433_class);
unregister_chrdev(MAJOR(pi433_devt),
pi433_spi_driver.driver.name);
}
if (status < 0)
goto unreg_class_and_remove_dbfs;
return 0;
unreg_class_and_remove_dbfs:
class_unregister(&pi433_class);
unreg_chrdev:
unregister_chrdev(MAJOR(pi433_devt), pi433_spi_driver.driver.name);
return status;
}