github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-22 04:34:03 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

ALSA: core: propagate actual error code from register_chrdev

Browse Source 
The alsa_sound_init() function currently returns a hardcoded -EIO
if register_chrdev() fails, masking specific error codes from
__register_chrdev() such as -EINVAL, -ENOMEM, or -EBUSY.

Masking these failures under a generic -EIO makes system-level
diagnostics unnecessarily difficult. Propagating explicit error codes
from register_chrdev() is also an established convention widely
practiced across other subsystems.

Fix this by capturing and propagating the dynamic error code from
register_chrdev(). While at it, also assign the return value of
snd_info_init() to the 'err' variable instead of hardcoding -ENOMEM
to ensure consistency and future-proofing.

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
Link: https://patch.msgid.link/20260703103840.253527-1-phucduc.bui@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
bui duc phuc 2026-07-03 17:38:40 +07:00 committed by Takashi Iwai
parent b8c89ae642
commit bd8f218761
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
sound/core/sound.c
View File

@ -395,15 +395,21 @@ int __init snd_minor_info_init(void)
static int __init alsa_sound_init(void)
{
int err;
snd_major = major;
snd_ecards_limit = cards_limit;
if (register_chrdev(major, "alsa", &snd_fops)) {
err = register_chrdev(major, "alsa", &snd_fops);
if (err < 0) {
pr_err("ALSA core: unable to register native major device number %d\n", major);
return -EIO;
return err;
}
if (snd_info_init() < 0) {
err = snd_info_init();
if (err < 0) {
unregister_chrdev(major, "alsa");
return -ENOMEM;
return err;
}
#ifdef CONFIG_SND_DEBUG