From bd6b9bbd82a01212536b57fa6d7ab7741da5d7cb Mon Sep 17 00:00:00 2001 From: Kees Cook Date: Thu, 17 Sep 2026 14:13:33 -0700 Subject: [PATCH] hwmon: (asus_wmi_sensors) Fix info[] allocation type In preparation for making the devm_kmalloc family of allocators type aware, we need to make sure that the returned type from the allocation matches the type of the variable being assigned. (Before, the allocator would always return "void *", which can be implicitly cast to any pointer type.) The assigned type of "sensor_data->wmi.info[type]" is "const struct asus_wmi_sensor_info **", but the converted allocation type would be "const struct asus_wmi_sensor_info ***", as the size was taken from "*sensor_data->wmi.info", which is one level of indirection too many. Luckily both element types are pointers of the same size. Take the size from the element type of the assignment target. Build tested ARCH=x86_64 allmodconfig with GCC 16.2.0: drivers/hwmon/asus_wmi_sensors.o Assisted-by: LLM coccinelle Signed-off-by: Kees Cook Link: https://patch.msgid.link/20260917211332.i.711-kees@kernel.org Signed-off-by: Guenter Roeck --- drivers/hwmon/asus_wmi_sensors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/asus_wmi_sensors.c b/drivers/hwmon/asus_wmi_sensors.c index c2dd7ff882f2..621e3506972d 100644 --- a/drivers/hwmon/asus_wmi_sensors.c +++ b/drivers/hwmon/asus_wmi_sensors.c @@ -573,7 +573,7 @@ static int asus_wmi_configure_sensor_setup(struct device *dev, sensor_data->wmi.info[type] = devm_kcalloc(dev, nr_count[type], - sizeof(*sensor_data->wmi.info), + sizeof(*sensor_data->wmi.info[type]), GFP_KERNEL); if (!sensor_data->wmi.info[type]) return -ENOMEM;