github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-22 04:34:03 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

drm/solomon: use ssd130x_run_cmd_seq() in ssd132x_init()

Browse Source 
Replace individual ssd130x_write_cmd() calls and per-command error
checks with a flat command array dispatched through ssd130x_run_cmd_seq().

Signed-off-by: Alberto Ruiz <aruiz@redhat.com>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Tested-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patch.msgid.link/20260612-ssd-batchcmd-v1-3-c61e5f7c24bc@redhat.com
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
This commit is contained in:
Alberto Ruiz 2026-06-12 18:17:18 +01:00 committed by Javier Martinez Canillas
parent 5ff55125d8
commit bc9f61ef36
No known key found for this signature in database
GPG Key ID: C751E590D63F3D69
1 changed files with 26 additions and 85 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

111
drivers/gpu/drm/solomon/ssd130x.c
View File

@ -553,92 +553,33 @@ static int ssd130x_init(struct ssd130x_device *ssd130x)
static int ssd132x_init(struct ssd130x_device *ssd130x)
{
int ret;
const u8 cmds[] = {
2, SSD13XX_CONTRAST, 0x80,
3, SSD132X_SET_COL_RANGE, 0x00, ssd130x->width / SSD132X_SEGMENT_WIDTH - 1,
3, SSD132X_SET_ROW_RANGE, 0x00, ssd130x->height - 1,
/*
* Horizontal Address Increment
* Re-map for Column Address, Nibble and COM
* COM Split Odd Even
*/
2, SSD13XX_SET_SEG_REMAP, 0x53,
2, SSD132X_SET_DISPLAY_START, 0x00,
2, SSD132X_SET_DISPLAY_OFFSET, 0x00,
1, SSD132X_SET_DISPLAY_NORMAL,
2, SSD13XX_SET_MULTIPLEX_RATIO, ssd130x->height - 1,
2, SSD132X_SET_PHASE_LENGTH, 0x55,
1, SSD132X_SELECT_DEFAULT_TABLE,
2, SSD132X_SET_CLOCK_FREQ, 0x01,
2, SSD132X_SET_FUNCTION_SELECT_A, 0x1,
2, SSD132X_SET_PRECHARGE_PERIOD, 0x01,
2, SSD132X_SET_PRECHARGE_VOLTAGE, 0x08,
2, SSD130X_SET_VCOMH_VOLTAGE, 0x07,
/* Enable second pre-charge and internal VSL */
2, SSD132X_SET_FUNCTION_SELECT_B, 0x62,
0,
};
/* Set initial contrast */
ret = ssd130x_write_cmd(ssd130x, 2, SSD13XX_CONTRAST, 0x80);
if (ret < 0)
return ret;
/* Set column start and end */
ret = ssd130x_write_cmd(ssd130x, 3, SSD132X_SET_COL_RANGE, 0x00,
ssd130x->width / SSD132X_SEGMENT_WIDTH - 1);
if (ret < 0)
return ret;
/* Set row start and end */
ret = ssd130x_write_cmd(ssd130x, 3, SSD132X_SET_ROW_RANGE, 0x00, ssd130x->height - 1);
if (ret < 0)
return ret;
/*
* Horizontal Address Increment
* Re-map for Column Address, Nibble and COM
* COM Split Odd Even
*/
ret = ssd130x_write_cmd(ssd130x, 2, SSD13XX_SET_SEG_REMAP, 0x53);
if (ret < 0)
return ret;
/* Set display start and offset */
ret = ssd130x_write_cmd(ssd130x, 2, SSD132X_SET_DISPLAY_START, 0x00);
if (ret < 0)
return ret;
ret = ssd130x_write_cmd(ssd130x, 2, SSD132X_SET_DISPLAY_OFFSET, 0x00);
if (ret < 0)
return ret;
/* Set display mode normal */
ret = ssd130x_write_cmd(ssd130x, 1, SSD132X_SET_DISPLAY_NORMAL);
if (ret < 0)
return ret;
/* Set multiplex ratio value */
ret = ssd130x_write_cmd(ssd130x, 2, SSD13XX_SET_MULTIPLEX_RATIO, ssd130x->height - 1);
if (ret < 0)
return ret;
/* Set phase length */
ret = ssd130x_write_cmd(ssd130x, 2, SSD132X_SET_PHASE_LENGTH, 0x55);
if (ret < 0)
return ret;
/* Select default linear gray scale table */
ret = ssd130x_write_cmd(ssd130x, 1, SSD132X_SELECT_DEFAULT_TABLE);
if (ret < 0)
return ret;
/* Set clock frequency */
ret = ssd130x_write_cmd(ssd130x, 2, SSD132X_SET_CLOCK_FREQ, 0x01);
if (ret < 0)
return ret;
/* Enable internal VDD regulator */
ret = ssd130x_write_cmd(ssd130x, 2, SSD132X_SET_FUNCTION_SELECT_A, 0x1);
if (ret < 0)
return ret;
/* Set pre-charge period */
ret = ssd130x_write_cmd(ssd130x, 2, SSD132X_SET_PRECHARGE_PERIOD, 0x01);
if (ret < 0)
return ret;
/* Set pre-charge voltage */
ret = ssd130x_write_cmd(ssd130x, 2, SSD132X_SET_PRECHARGE_VOLTAGE, 0x08);
if (ret < 0)
return ret;
/* Set VCOMH voltage */
ret = ssd130x_write_cmd(ssd130x, 2, SSD130X_SET_VCOMH_VOLTAGE, 0x07);
if (ret < 0)
return ret;
/* Enable second pre-charge and internal VSL */
ret = ssd130x_write_cmd(ssd130x, 2, SSD132X_SET_FUNCTION_SELECT_B, 0x62);
if (ret < 0)
return ret;
return 0;
return ssd130x_run_cmd_seq(ssd130x, cmds);
}
static int ssd133x_init(struct ssd130x_device *ssd130x)