github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-07 14:04:54 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

ANDROID: Incremental fs: stat should return actual used blocks

Browse Source 
Test: incfs_test passes
Bug: 182182100
Signed-off-by: Paul Lawrence <paullawrence@google.com>
Change-Id: I4c9e5f111fbb659798ef79bc20d8a65b64b44ded
This commit is contained in:
Paul Lawrence 2021-04-01 10:08:32 -07:00
parent f4c368a3f9
commit ba9602b155
2 changed files with 70 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
fs/incfs/vfs.c
View File

@ -1611,18 +1611,29 @@ static int incfs_getattr(const struct path *path,
{ {
struct inode *inode = d_inode(path->dentry); struct inode *inode = d_inode(path->dentry);
generic_fillattr(inode, stat);
stat->attributes &= ~STATX_ATTR_VERITY;
if (IS_VERITY(inode)) if (IS_VERITY(inode))
stat->attributes |= STATX_ATTR_VERITY; stat->attributes |= STATX_ATTR_VERITY;
stat->attributes_mask |= STATX_ATTR_VERITY; stat->attributes_mask |= STATX_ATTR_VERITY;
generic_fillattr(inode, stat);
/* if (request_mask & STATX_BLOCKS) {
* TODO: stat->blocks is wrong at this point. It should be number of struct kstat backing_kstat;
* blocks in the backing file. But that information is not (necessarily) struct dentry_info *di = get_incfs_dentry(path->dentry);
* available yet - incfs_open_dir_file may not have been called. int error = 0;
* Solution is probably to store the backing file block count in an struct path *backing_path;
* xattr whenever it's changed.
*/ if (!di)
return -EFSCORRUPTED;
backing_path = &di->backing_path;
error = vfs_getattr(backing_path, &backing_kstat, STATX_BLOCKS,
AT_STATX_SYNC_AS_STAT);
if (error)
return error;
stat->blocks = backing_kstat.blocks;
}
return 0; return 0;
} }

51
tools/testing/selftests/filesystems/incfs/incfs_test.c
View File

@ -4277,6 +4277,56 @@ static int truncate_test(const char *mount_dir)
return result; return result;
} }
static int stat_file_test(const char *mount_dir, int cmd_fd,
struct test_file *file)
{
int result = TEST_FAILURE;
struct stat st;
char *filename = NULL;
TESTEQUAL(emit_file(cmd_fd, NULL, file->name, &file->id,
file->size, NULL), 0);
TEST(filename = concat_file_name(mount_dir, file->name), filename);
TESTEQUAL(stat(filename, &st), 0);
TESTCOND(st.st_blocks < 32);
TESTEQUAL(emit_test_file_data(mount_dir, file), 0);
TESTEQUAL(stat(filename, &st), 0);
TESTCOND(st.st_blocks > file->size / 512);
result = TEST_SUCCESS;
out:
free(filename);
return result;
}
static int stat_test(const char *mount_dir)
{
int result = TEST_FAILURE;
char *backing_dir = NULL;
int cmd_fd = -1;
int i;
struct test_files_set test = get_test_files_set();
const int file_num = test.files_count;
TEST(backing_dir = create_backing_dir(mount_dir), backing_dir);
TESTEQUAL(mount_fs(mount_dir, backing_dir, 0), 0);
TEST(cmd_fd = open_commands_file(mount_dir), cmd_fd != -1);
for (i = 0; i < file_num; i++) {
struct test_file *file = &test.files[i];
TESTEQUAL(stat_file_test(mount_dir, cmd_fd, file), 0);
}
result = TEST_SUCCESS;
out:
close(cmd_fd);
umount(mount_dir);
free(backing_dir);
return result;
}
static char *setup_mount_dir() static char *setup_mount_dir()
{ {
struct stat st; struct stat st;
@ -4395,6 +4445,7 @@ int main(int argc, char *argv[])
MAKE_TEST(enable_verity_test), MAKE_TEST(enable_verity_test),
MAKE_TEST(mmap_test), MAKE_TEST(mmap_test),
MAKE_TEST(truncate_test), MAKE_TEST(truncate_test),
MAKE_TEST(stat_test),
}; };
#undef MAKE_TEST #undef MAKE_TEST