github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-07 06:17:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

dm-crypt: Reject malformed raw keys in crypt_set_key()

Browse Source 
dm-crypt calculates the raw key size by dividing the hex string length
by two. If the string has an odd number of characters, the key size is
rounded down and hex2bin() only decodes complete byte pairs.

For example, a 33-character raw key string is malformed, but dm-crypt
treats it as a 16-byte key and ignores the last character.

Reject raw key strings whose length does not match the expected number
of hex characters. This restores the trailing character check that was
lost when the open-coded decoder was replaced with hex2bin().

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
This commit is contained in:
Thorsten Blum 2026-08-13 10:13:36 +02:00 committed by Mikulas Patocka
parent 769d5353c8
commit ba56ca86f9
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/md/dm-crypt.c
View File

@ -2614,6 +2614,9 @@ static int crypt_set_key(struct crypt_config *cc, char *key)
kfree_sensitive(cc->key_string);
cc->key_string = NULL;
if (cc->key_size && key_string_len != cc->key_size * 2)
goto out;
/* Decode key from its hex representation. */
if (cc->key_size && hex2bin(cc->key, key, cc->key_size) < 0)
goto out;