From 38d5387b7660476fd7e8e07d16ee436819e3544d Mon Sep 17 00:00:00 2001 From: Luca Ceresoli Date: Wed, 3 Apr 2024 13:03:18 +0200 Subject: [PATCH 1/2] ASoC: codecs: rk3308: fix "defined but not used" warning on !OF Building with CONFIG_OF=n triggers: warning: 'rk3308_codec_of_match' defined but not used [-Wunused-const-variable=] warning: unused variable 'rk3308_codec_of_match' [-Wunused-const-variable] Even though OF is needed for probing, fix by declaring as __maybe_unused to still allow building on non-OF configurations for build testing. Fixes: 9fdd7b45da18 ("arm64: defconfig: enable Rockchip RK3308 internal audio codec driver") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202403271905.BYbGJiPi-lkp@intel.com/ Closes: https://lore.kernel.org/oe-kbuild-all/202403271907.0z0uuG5I-lkp@intel.com/ Signed-off-by: Luca Ceresoli Link: https://msgid.link/r/20240403-rk3308-audio-codec-fix-warning-v2-1-816bae4c1dc5@bootlin.com Signed-off-by: Mark Brown --- sound/soc/codecs/rk3308_codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/rk3308_codec.c b/sound/soc/codecs/rk3308_codec.c index 9d3e4691a7b5..74c3836995b1 100644 --- a/sound/soc/codecs/rk3308_codec.c +++ b/sound/soc/codecs/rk3308_codec.c @@ -953,7 +953,7 @@ static int rk3308_codec_platform_probe(struct platform_device *pdev) return 0; } -static const struct of_device_id rk3308_codec_of_match[] = { +static const struct of_device_id __maybe_unused rk3308_codec_of_match[] = { { .compatible = "rockchip,rk3308-codec", }, {}, }; From 03246ade4646653bbc98fa6fa506891a51983259 Mon Sep 17 00:00:00 2001 From: Luca Ceresoli Date: Wed, 3 Apr 2024 13:03:19 +0200 Subject: [PATCH 2/2] ASoC: codecs: rk3308: depend on ARM64 || COMPILE_TEST This codec is only known to exist in the RK3308 ARM64 SoC, so depend on it except for compile test cases. Note that the driver won't probe without CONFIG_OF, but ARM64 selects OF already so it is not needed. Suggested-by: Mark Brown Signed-off-by: Luca Ceresoli Link: https://msgid.link/r/20240403-rk3308-audio-codec-fix-warning-v2-2-816bae4c1dc5@bootlin.com Signed-off-by: Mark Brown --- sound/soc/codecs/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 1752814fffdd..4e47bb6850aa 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -1436,6 +1436,7 @@ config SND_SOC_PEB2466 config SND_SOC_RK3308 tristate "Rockchip RK3308 audio CODEC" + depends on ARM64 || COMPILE_TEST select REGMAP_MMIO help This is a device driver for the audio codec embedded in the