github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-28 09:04:39 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

iio: light: al3320a: Fix an error handling path in al3320a_probe()

Browse Source 
If regmap_write() fails in al3320a_init(), al3320a_set_pwr_off is
not called.

In order to avoid such a situation, move the devm_add_action_or_reset()
which calls al3320a_set_pwr_off right after a successful
al3320a_set_pwr_on.

Signed-off-by: David Heidelberg <david@ixit.cz>
Link: https://patch.msgid.link/20250402-al3010-iio-regmap-v4-3-d189bea87261@ixit.cz
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
David Heidelberg 2025-04-02 21:33:26 +02:00 committed by Jonathan Cameron
parent c0461f8e84
commit b8154f3477
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/iio/light/al3320a.c
View File

@ -101,6 +101,12 @@ static int al3320a_init(struct al3320a_data *data)
if (ret < 0)
return ret;
ret = devm_add_action_or_reset(&data->client->dev,
al3320a_set_pwr_off,
data);
if (ret)
return ret;
ret = i2c_smbus_write_byte_data(data->client, AL3320A_REG_CONFIG_RANGE,
FIELD_PREP(AL3320A_GAIN_MASK,
AL3320A_RANGE_3));
@ -211,10 +217,6 @@ static int al3320a_probe(struct i2c_client *client)
return ret;
}
ret = devm_add_action_or_reset(dev, al3320a_set_pwr_off, data);
if (ret < 0)
return ret;
return devm_iio_device_register(dev, indio_dev);
}