github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-22 22:22:08 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

perf stat: Stop repeating when ref_perf_stat() returns -1

Browse Source 
Exit when run_perf_stat() returns an error to avoid continuously
repeating the same error message. It's not expected that COUNTER_FATAL
or internal errors are recoverable so there's no point in retrying.

This fixes the following flood of error messages for permission issues,
for example when perf_event_paranoid==3:
  perf stat -r 1044 -- false

  Error:
  Access to performance monitoring and observability operations is limited.
  ...
  Error:
  Access to performance monitoring and observability operations is limited.
  ...
  (repeating for 1044 times).

Signed-off-by: Levi Yun <yeoreum.yun@arm.com>
Reviewed-by: James Clark <james.clark@linaro.org>
Cc: nd@arm.com
Cc: howardchu95@gmail.com
Link: https://lore.kernel.org/r/20240925132022.2650180-3-yeoreum.yun@arm.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
This commit is contained in:
Levi Yun 2024-09-25 14:20:22 +01:00 committed by Namhyung Kim
parent e880a70f80
commit b77f8c36ce
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tools/perf/builtin-stat.c
View File

@ -968,6 +968,14 @@ static int __run_perf_stat(int argc, const char **argv, int run_idx)
return err;
}
/*
* Returns -1 for fatal errors which signifies to not continue
* when in repeat mode.
*
* Returns < -1 error codes when stat record is used. These
* result in the stat information being displayed, but writing
* to the file fails and is non fatal.
*/
static int run_perf_stat(int argc, const char **argv, int run_idx)
{
int ret;
@ -2899,7 +2907,10 @@ int cmd_stat(int argc, const char **argv)
evlist__reset_prev_raw_counts(evsel_list);
status = run_perf_stat(argc, argv, run_idx);
if (forever && status != -1 && !interval) {
if (status == -1)
break;
if (forever && !interval) {
print_counters(NULL, argc, argv);
perf_stat__reset_stats();
}