From b728c07e309ff135e52f8d073b68f23bd0052d6c Mon Sep 17 00:00:00 2001 From: Cezary Rojewski Date: Fri, 25 Sep 2026 11:39:28 +0200 Subject: [PATCH] driver core: platform: Simplify platform_device_alloc() There is no need to double check the 'pa' object. Reviewed-by: Dawid Osuchowski Signed-off-by: Cezary Rojewski Reviewed-by: Vishal Moola (Fractile) Link: https://patch.msgid.link/20260925093928.3765486-1-cezary.rojewski@intel.com Signed-off-by: Danilo Krummrich --- drivers/base/platform.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/base/platform.c b/drivers/base/platform.c index 66f9ec73d47e..3593d45f4a7a 100644 --- a/drivers/base/platform.c +++ b/drivers/base/platform.c @@ -632,16 +632,17 @@ struct platform_device *platform_device_alloc(const char *name, int id) struct platform_object *pa; pa = kzalloc(sizeof(*pa) + strlen(name) + 1, GFP_KERNEL); - if (pa) { - strcpy(pa->name, name); - pa->pdev.name = pa->name; - pa->pdev.id = id; - device_initialize(&pa->pdev.dev); - pa->pdev.dev.release = platform_device_release; - setup_pdev_dma_masks(&pa->pdev); - } + if (!pa) + return NULL; - return pa ? &pa->pdev : NULL; + strcpy(pa->name, name); + pa->pdev.name = pa->name; + pa->pdev.id = id; + device_initialize(&pa->pdev.dev); + pa->pdev.dev.release = platform_device_release; + setup_pdev_dma_masks(&pa->pdev); + + return &pa->pdev; } EXPORT_SYMBOL_GPL(platform_device_alloc);