From b702739a31e4250db2dc2bd232cacc1e555df365 Mon Sep 17 00:00:00 2001 From: Kees Cook Date: Thu, 17 Sep 2026 14:13:39 -0700 Subject: [PATCH] hwmon: (hp-wmi-sensors) Fix info_map[] allocation type In preparation for making the devm_kmalloc family of allocators type aware, we need to make sure that the returned type from the allocation matches the type of the variable being assigned. (Before, the allocator would always return "void *", which can be implicitly cast to any pointer type.) The assigned type of "info_map[type]" is "struct hp_wmi_info **", but the converted allocation type would be "struct hp_wmi_info ***", as the size was taken from "*info_map", which is one level of indirection too many. Luckily both element types are pointers of the same size. Take the size from the element type of the assignment target. Build tested ARCH=x86_64 allmodconfig with GCC 16.2.0: drivers/hwmon/hp-wmi-sensors.o Assisted-by: LLM coccinelle Signed-off-by: Kees Cook Acked-by: James Seo Link: https://patch.msgid.link/20260917211338.i.682-kees@kernel.org Signed-off-by: Guenter Roeck --- drivers/hwmon/hp-wmi-sensors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/hp-wmi-sensors.c b/drivers/hwmon/hp-wmi-sensors.c index cfa0d6ad0fb3..d8bcfeb8d5b2 100644 --- a/drivers/hwmon/hp-wmi-sensors.c +++ b/drivers/hwmon/hp-wmi-sensors.c @@ -1804,7 +1804,7 @@ static int init_numeric_sensors(struct hp_wmi_sensors *state, if (!info_map[type]) { info_map[type] = devm_kcalloc(dev, channel_count[type], - sizeof(*info_map), + sizeof(*info_map[type]), GFP_KERNEL); if (!info_map[type]) return -ENOMEM;