github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-10 23:53:52 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

mdm6600: Reduce memory usage

Browse Source 
buffer_sz is multiple of MaxPacketSize because the USB host controller
can split the buffer in packets.

All buffers received or sent are <2k, so MaxPacketSize * 4 (2k) should
be a better buffer size.

Change-Id: I1e0e2fd4e9a4e78d33e6b4de57ee420630298de2
Signed-off-by: Benoit Goby <benoit@android.com>
This commit is contained in:
Benoit Goby 2010-09-30 17:20:22 -07:00 committed by Colin Cross
parent bfea4fcd5b
commit b431ff4ebe
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/usb/serial/mdm6600.c
View File

@ -169,9 +169,7 @@ static int mdm6600_attach(struct usb_serial *serial)
spin_lock_init(&modem->write.busy_lock);
init_usb_anchor(&modem->write.in_flight);
init_usb_anchor(&modem->write.delayed);
/* The * 20 calculation is from Motorola's original driver, I do not
* know the reasoning */
modem->write.buffer_sz = le16_to_cpu(epwrite->wMaxPacketSize) * 20;
modem->write.buffer_sz = le16_to_cpu(epwrite->wMaxPacketSize) * 4;
for (i = 0; i < POOL_SZ; i++) {
struct urb *u = usb_alloc_urb(0, GFP_KERNEL);
if (!u)
@ -193,9 +191,7 @@ static int mdm6600_attach(struct usb_serial *serial)
INIT_WORK(&modem->read.work, mdm6600_read_bulk_work);
init_usb_anchor(&modem->read.in_flight);
init_usb_anchor(&modem->read.pending);
/* The * 2 calculation is from Motorola's original driver, I do not
* know the reasoning */
modem->read.buffer_sz = le16_to_cpu(epread->wMaxPacketSize) * 2;
modem->read.buffer_sz = le16_to_cpu(epread->wMaxPacketSize) * 4;
for (i = 0; i < POOL_SZ; i++) {
struct urb *u = usb_alloc_urb(0, GFP_KERNEL);
if (!u)