github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-27 16:44:58 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

wifi: rtw88: add quirks to disable PCI ASPM and deep LPS for HP P3S95EA#ACB

Browse Source 
On an HP laptop (P3S95EA#ACB) equipped with a Realtek RTL8821CE 802.11ac
PCIe adapter (PCI ID: 10ec:c821), the system experiences a hard lockup
(complete freeze of the UI and kernel, sysrq doesn't work, requires
holding the power button) when the WiFi adapter enters the power
saving state. Disable PCI ASPM to avoid system freeze.

In addition, driver throws messages periodically. Though this doesn't
always cause unstable connection, missing H2C commands might cause
unpredictable results. Disable deep LPS to avoid this as well.

 rtw88_8821ce 0000:13:00.0: firmware failed to leave lps state
 rtw88_8821ce 0000:13:00.0: failed to send h2c command
 rtw88_8821ce 0000:13:00.0: failed to send h2c command

Tested on HP Notebook P3S95EA#ACB (kernel 6.19.7-1-cachyos):

  - No hard freeze observed during idle or active usage.
  - Zero h2c or lps errors in dmesg across idle (10 min),
    load stress (100MB download), and suspend/resume cycle.
  - Both quirk flags confirmed active via sysfs without any
    manual modprobe parameters.

Reported-by: Oleksandr Havrylov <goainwo@gmail.com>
Closes: https://lore.kernel.org/linux-wireless/CALdGYqSQ1Ko2TTBhUizMu_FvLMUAuQfFrVwS10n_C-LSQJQQkQ@mail.gmail.com/
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Tested-by: Oleksandr Havrylov <goainwo@gmail.com>
Link: https://patch.msgid.link/20260316035635.16550-1-pkshih@realtek.com
This commit is contained in:
Ping-Ke Shih 2026-03-16 11:56:35 +08:00
parent eef6d4449e
commit b2bf9d61e1
2 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/wireless/realtek/rtw88/main.h
View File

@ -432,6 +432,11 @@ enum rtw_wow_flags {
RTW_WOW_FLAG_MAX,
};
enum rtw_quirk_dis_caps {
QUIRK_DIS_CAP_PCI_ASPM,
QUIRK_DIS_CAP_LPS_DEEP,
};
/* the power index is represented by differences, which cck-1s & ht40-1s are
* the base values, so for 1s's differences, there are only ht20 & ofdm
*/

31
drivers/net/wireless/realtek/rtw88/pci.c
View File

@ -2,6 +2,7 @@
/* Copyright(c) 2018-2019 Realtek Corporation
*/
#include <linux/dmi.h>
#include <linux/module.h>
#include <linux/pci.h>
#include "main.h"
@ -1744,6 +1745,34 @@ const struct pci_error_handlers rtw_pci_err_handler = {
};
EXPORT_SYMBOL(rtw_pci_err_handler);
static int rtw_pci_disable_caps(const struct dmi_system_id *dmi)
{
uintptr_t dis_caps = (uintptr_t)dmi->driver_data;
if (dis_caps & BIT(QUIRK_DIS_CAP_PCI_ASPM))
rtw_pci_disable_aspm = true;
if (dis_caps & BIT(QUIRK_DIS_CAP_LPS_DEEP))
rtw_disable_lps_deep_mode = true;
return 1;
}
static const struct dmi_system_id rtw_pci_quirks[] = {
{
.callback = rtw_pci_disable_caps,
.ident = "HP Notebook - P3S95EA#ACB",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "HP"),
DMI_MATCH(DMI_PRODUCT_NAME, "HP Notebook"),
DMI_MATCH(DMI_PRODUCT_SKU, "P3S95EA#ACB"),
},
.driver_data = (void *)(BIT(QUIRK_DIS_CAP_PCI_ASPM) |
BIT(QUIRK_DIS_CAP_LPS_DEEP)),
},
{}
};
int rtw_pci_probe(struct pci_dev *pdev,
const struct pci_device_id *id)
{
@ -1771,6 +1800,8 @@ int rtw_pci_probe(struct pci_dev *pdev,
rtwpci = (struct rtw_pci *)rtwdev->priv;
atomic_set(&rtwpci->link_usage, 1);
dmi_check_system(rtw_pci_quirks);
ret = rtw_core_init(rtwdev);
if (ret)
goto err_release_hw;