github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-01 11:03:43 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

drm/i915/selftests: fix smatch warning in mock_reserve

Browse Source 
If mock_region_create fails then mem will be an error pointer. Instead
we just need to use the correct ordering for the onion unwind.

igt_mock_reserve() error: 'mem' dereferencing possible ERR_PTR()

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Reviewed-by: Ramalingam C <ramalingam.c@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210702104642.1189978-2-matthew.auld@intel.com
This commit is contained in:
Matthew Auld 2021-07-02 11:46:42 +01:00
parent 0c1145e05c
commit b23228f287
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/gpu/drm/i915/selftests/intel_memory_region.c
View File

@ -173,7 +173,7 @@ static int igt_mock_reserve(void *arg)
if (IS_ERR(mem)) { if (IS_ERR(mem)) {
pr_err("failed to create memory region\n"); pr_err("failed to create memory region\n");
err = PTR_ERR(mem); err = PTR_ERR(mem);
goto out_close; goto out_free_order;
} }
/* Reserve a bunch of ranges within the region */ /* Reserve a bunch of ranges within the region */
@ -224,9 +224,10 @@ static int igt_mock_reserve(void *arg)
} }
out_close: out_close:
kfree(order);
close_objects(mem, &objects); close_objects(mem, &objects);
intel_memory_region_put(mem); intel_memory_region_put(mem);
out_free_order:
kfree(order);
return err; return err;
} }