github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-28 18:21:24 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

RDMA/efa: Validate SQ ring size against max LLQ size

Browse Source 
Validate the SQ ring size against the device's max LLQ size. This
ensures that when using 128-byte WQEs, userspace cannot exceed the queue
limits.

On create QP, userspace provides the SQ ring size (depth x WQE size)
which is validated against the max LLQ size.

Fixes: 40909f664d ("RDMA/efa: Add EFA verbs implementation")
Link: https://patch.msgid.link/r/20260526081536.1203553-1-ynachum@amazon.com
Reviewed-by: Michael Margolin <mrgolin@amazon.com>
Signed-off-by: Yonatan Nachum <ynachum@amazon.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
This commit is contained in:
Yonatan Nachum 2026-05-26 08:15:36 +00:00 committed by Jason Gunthorpe
parent 4a1b1ac274
commit b230b57bd6
1 changed files with 18 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
drivers/infiniband/hw/efa/efa_verbs.c
View File

@ -613,7 +613,8 @@ static int qp_mmap_entries_setup(struct efa_qp *qp,
}
static int efa_qp_validate_cap(struct efa_dev *dev,
struct ib_qp_init_attr *init_attr)
struct ib_qp_init_attr *init_attr,
u32 sq_ring_size)
{
if (init_attr->cap.max_send_wr > dev->dev_attr.max_sq_depth) {
ibdev_dbg(&dev->ibdev,
@ -622,6 +623,14 @@ static int efa_qp_validate_cap(struct efa_dev *dev,
dev->dev_attr.max_sq_depth);
return -EINVAL;
}
if (sq_ring_size > dev->dev_attr.max_llq_size) {
ibdev_dbg(&dev->ibdev,
"qp: requested sq ring size[%u] exceeds the max[%u]\n",
sq_ring_size, dev->dev_attr.max_llq_size);
return -EINVAL;
}
if (init_attr->cap.max_recv_wr > dev->dev_attr.max_rq_depth) {
ibdev_dbg(&dev->ibdev,
"qp: requested receive wr[%u] exceeds the max[%u]\n",
@ -691,14 +700,6 @@ int efa_create_qp(struct ib_qp *ibqp, struct ib_qp_init_attr *init_attr,
ucontext = rdma_udata_to_drv_context(udata, struct efa_ucontext,
ibucontext);
err = efa_qp_validate_cap(dev, init_attr);
if (err)
goto err_out;
err = efa_qp_validate_attr(dev, init_attr);
if (err)
goto err_out;
err = ib_copy_validate_udata_in_cm(udata, cmd, driver_qp_type, 0);
if (err)
goto err_out;
@ -720,6 +721,14 @@ int efa_create_qp(struct ib_qp *ibqp, struct ib_qp_init_attr *init_attr,
goto err_out;
}
err = efa_qp_validate_cap(dev, init_attr, cmd.sq_ring_size);
if (err)
goto err_out;
err = efa_qp_validate_attr(dev, init_attr);
if (err)
goto err_out;
create_qp_params.uarn = ucontext->uarn;
create_qp_params.pd = to_epd(ibqp->pd)->pdn;