github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-22 12:44:03 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

mfd: si476x-i2c: Get rid of duplicate NULL checks

Browse Source 
GPIO descriptor APIs are NULL-aware and since the requested line is optional
we don't need to have an additional check each time we want to toggle GPIO.

Get rid of duplicate NULL checks.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20260715191603.1325479-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Lee Jones <lee@kernel.org>
This commit is contained in:
Andy Shevchenko 2026-07-15 21:16:03 +02:00 committed by Lee Jones
parent a764e2a617
commit b1eb3de64d
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/mfd/si476x-i2c.c
View File

@ -130,8 +130,7 @@ int si476x_core_start(struct si476x_core *core, bool soft)
int err;
if (!soft) {
if (core->reset)
gpiod_set_value_cansleep(core->reset, 0);
gpiod_set_value_cansleep(core->reset, 0);
if (client->irq)
enable_irq(client->irq);
@ -197,8 +196,7 @@ int si476x_core_start(struct si476x_core *core, bool soft)
else
cancel_delayed_work_sync(&core->status_monitor);
if (core->reset)
gpiod_set_value_cansleep(core->reset, 1);
gpiod_set_value_cansleep(core->reset, 1);
return err;
}
@ -242,10 +240,9 @@ int si476x_core_stop(struct si476x_core *core, bool soft)
else
cancel_delayed_work_sync(&core->status_monitor);
if (!soft) {
if (core->reset)
gpiod_set_value_cansleep(core->reset, 1);
}
if (!soft)
gpiod_set_value_cansleep(core->reset, 1);
return err;
}
EXPORT_SYMBOL_GPL(si476x_core_stop);