From b00d6a73981ee4fb289e89ab649ce61a8df54cd9 Mon Sep 17 00:00:00 2001 From: Deborah Brouwer Date: Thu, 9 Apr 2026 10:51:25 -0700 Subject: [PATCH] drm/tyr: Print GPU_ID without filtering Currently, Tyr prints just the upper 16 bits of the GPU_ID in the hex id field, namely ARCH_MAJOR, ARCH_MINOR, ARCH_REV, and PRODUCT_MAJOR. The VERSION_* fields are already printed separately as "major", "minor", and "status". Print the full 32-bit GPU_ID register instead of shifting it, so the hex id reflects the complete register contents. Before this change: mali-g610 id 0xa867 major 0x0 minor 0x0 status 0x5 After this change: mali-g610 GPU_ID 0xa8670005 major 0x0 minor 0x0 status 0x5 Reviewed-by: Boris Brezillon Signed-off-by: Deborah Brouwer Link: https://patch.msgid.link/20260409-b4-tyr-use-register-macro-v5-v5-2-8abfff8a0204@collabora.com Signed-off-by: Alice Ryhl --- drivers/gpu/drm/tyr/gpu.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tyr/gpu.rs b/drivers/gpu/drm/tyr/gpu.rs index 1e1e4103c575..652556026f50 100644 --- a/drivers/gpu/drm/tyr/gpu.rs +++ b/drivers/gpu/drm/tyr/gpu.rs @@ -97,9 +97,9 @@ pub(crate) fn log(&self, dev: &Device) { dev_info!( dev, - "mali-{} id 0x{:x} major 0x{:x} minor 0x{:x} status 0x{:x}", + "mali-{} GPU_ID 0x{:x} major 0x{:x} minor 0x{:x} status 0x{:x}", model_name, - gpu_id.into_raw() >> 16, + gpu_id.into_raw(), gpu_id.ver_major().get(), gpu_id.ver_minor().get(), gpu_id.ver_status().get()