github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-30 18:13:41 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

perf parse-events: Minor grouping tidy up

Browse Source 
Add comments. Ensure leader->group_name is freed before overwriting
it.

Signed-off-by: Ian Rogers <irogers@google.com>
Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
Tested-by: Atish Patra <atishp@rivosinc.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Beeman Strong <beeman@rivosinc.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20240416061533.921723-16-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Ian Rogers 2024-04-15 23:15:31 -07:00 committed by Arnaldo Carvalho de Melo
parent 4a20e79365
commit afd876bbdc
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tools/perf/util/parse-events.c
View File

@ -1711,6 +1711,7 @@ void parse_events__set_leader(char *name, struct list_head *list)
leader = list_first_entry(list, struct evsel, core.node); leader = list_first_entry(list, struct evsel, core.node);
__perf_evlist__set_leader(list, &leader->core); __perf_evlist__set_leader(list, &leader->core);
zfree(&leader->group_name);
leader->group_name = name; leader->group_name = name;
} }

6
tools/perf/util/parse-events.y
View File

@ -193,7 +193,10 @@ PE_NAME '{' events '}'
{ {
struct list_head *list = $3; struct list_head *list = $3;
/* Takes ownership of $1. */ /*
* Set the first entry of list to be the leader. Set the group name on
* the leader to $1 taking ownership.
*/
parse_events__set_leader($1, list); parse_events__set_leader($1, list);
$$ = list; $$ = list;
} }
@ -202,6 +205,7 @@ PE_NAME '{' events '}'
{ {
struct list_head *list = $2; struct list_head *list = $2;
/* Set the first entry of list to be the leader clearing the group name. */
parse_events__set_leader(NULL, list); parse_events__set_leader(NULL, list);
$$ = list; $$ = list;
} }