github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-29 10:41:49 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

ipv4: fib: Hold rtnl_net_lock() for ip_fib_net_exit().

Browse Source 
ip_fib_net_exit() requires RTNL and is called from fib_net_init()
and fib_net_exit_batch().

Let's hold rtnl_net_lock() before ip_fib_net_exit().

Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://patch.msgid.link/20250228042328.96624-10-kuniyu@amazon.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Kuniyuki Iwashima 2025-02-27 20:23:25 -08:00 committed by Jakub Kicinski
parent 9f7f3ebeba
commit af5cd2a8f0
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
net/ipv4/fib_frontend.c
View File

@ -1575,7 +1575,7 @@ static void ip_fib_net_exit(struct net *net)
{
int i;
ASSERT_RTNL();
ASSERT_RTNL_NET(net);
#ifdef CONFIG_IP_MULTIPLE_TABLES
RCU_INIT_POINTER(net->ipv4.fib_main, NULL);
RCU_INIT_POINTER(net->ipv4.fib_default, NULL);
@ -1635,9 +1635,9 @@ static int __net_init fib_net_init(struct net *net)
out_nlfl:
fib4_semantics_exit(net);
out_semantics:
rtnl_lock();
rtnl_net_lock(net);
ip_fib_net_exit(net);
rtnl_unlock();
rtnl_net_unlock(net);
goto out;
}
@ -1652,9 +1652,11 @@ static void __net_exit fib_net_exit_batch(struct list_head *net_list)
struct net *net;
rtnl_lock();
list_for_each_entry(net, net_list, exit_list)
list_for_each_entry(net, net_list, exit_list) {
__rtnl_net_lock(net);
ip_fib_net_exit(net);
__rtnl_net_unlock(net);
}
rtnl_unlock();
list_for_each_entry(net, net_list, exit_list)