github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-27 01:32:21 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

spi: dw-pci: remove redundant pci_free_irq_vectors() calls

Browse Source 
The driver uses pcim_enable_device(), so IRQ vectors are automatically
freed by devres on driver detach. The explicit pci_free_irq_vectors()
calls in the probe error path and remove function are redundant.

Drop them and the now-unused error label.

Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Link: https://patch.msgid.link/20260530-dw-pci-v1-1-5d2cf798b3c3@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Felix Gu 2026-05-30 02:54:31 +08:00 committed by Mark Brown
parent 7886054b06
commit af4310929a
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/spi/spi-dw-pci.c
View File

@ -120,16 +120,15 @@ static int dw_spi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *en
if (desc->setup) {
ret = desc->setup(dws);
if (ret)
goto err_free_irq_vectors;
return ret;
}
} else {
ret = -ENODEV;
goto err_free_irq_vectors;
return -ENODEV;
}
ret = dw_spi_add_controller(&pdev->dev, dws);
if (ret)
goto err_free_irq_vectors;
return ret;
/* PCI hook and SPI hook use the same drv data */
pci_set_drvdata(pdev, dws);
@ -143,10 +142,6 @@ static int dw_spi_pci_probe(struct pci_dev *pdev, const struct pci_device_id *en
pm_runtime_allow(&pdev->dev);
return 0;
err_free_irq_vectors:
pci_free_irq_vectors(pdev);
return ret;
}
static void dw_spi_pci_remove(struct pci_dev *pdev)
@ -157,7 +152,6 @@ static void dw_spi_pci_remove(struct pci_dev *pdev)
pm_runtime_get_noresume(&pdev->dev);
dw_spi_remove_controller(dws);
pci_free_irq_vectors(pdev);
}
#ifdef CONFIG_PM_SLEEP