r8152: Add support for the RTL8159 chip

The RTL8159 re-uses the packet descriptor format introduced with the
RTL8157 and other hardware features of the RTL8157 (RTL_VER_16) such
as the SRAM access. The support therefore consists in expanding the
existing RTL8157 code for initialization and USB power management
to also be used for the RTL8159 (RTL_VER_17).

Most of the additional code is added in r8157_hw_phy_cfg() to configure
the RTL8159 PHY.

Add support for the USB device ID of Realtek RTL8159-based adapters,
for which the product ID is 0x815a. Detect the RTL8159 as RTL_VER_17
and set it up.

Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
Tested-by: Aleksander Jan Bajkowski <olek2@wp.pl>
Link: https://patch.msgid.link/20260505-rtl8159_net_next-v4-2-1a648a9c4d8d@birger-koblitz.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Birger Koblitz 2026-05-05 17:56:34 +02:00 committed by Jakub Kicinski
parent 9774acd5fa
commit ad2a55b63b

View File

@ -1247,6 +1247,7 @@ enum rtl_version {
RTL_VER_14,
RTL_VER_15,
RTL_VER_16,
RTL_VER_17,
RTL_VER_MAX
};
@ -3432,6 +3433,7 @@ static void rtl8152_nic_reset(struct r8152 *tp)
break;
case RTL_VER_16:
case RTL_VER_17:
ocp_byte_clr_bits(tp, MCU_TYPE_PLA, PLA_CR, CR_RE | CR_TE);
break;
@ -3471,6 +3473,9 @@ static void rtl_eee_plus_en(struct r8152 *tp, bool enable)
static void rtl_set_eee_plus(struct r8152 *tp)
{
if (tp->version == RTL_VER_17)
return rtl_eee_plus_en(tp, false);
if (rtl8152_get_speed(tp) & _10bps)
rtl_eee_plus_en(tp, true);
else
@ -3656,6 +3661,7 @@ static void r8153_set_rx_early_timeout(struct r8152 *tp)
case RTL_VER_13:
case RTL_VER_15:
case RTL_VER_16:
case RTL_VER_17:
ocp_write_word(tp, MCU_TYPE_USB, USB_RX_EARLY_TIMEOUT,
640 / 8);
ocp_write_word(tp, MCU_TYPE_USB, USB_RX_EXTRA_AGGR_TMR,
@ -3700,6 +3706,7 @@ static void r8153_set_rx_early_size(struct r8152 *tp)
ocp_data / 8);
break;
case RTL_VER_16:
case RTL_VER_17:
ocp_write_word(tp, MCU_TYPE_USB, USB_RX_EARLY_SIZE,
ocp_data / 16);
break;
@ -4548,6 +4555,7 @@ static void rtl_clear_bp(struct r8152 *tp, u16 type)
break;
case RTL_VER_14:
case RTL_VER_16:
case RTL_VER_17:
default:
ocp_write_word(tp, type, USB_BP2_EN, 0);
bp_num = 16;
@ -5818,6 +5826,7 @@ static void rtl_eee_enable(struct r8152 *tp, bool enable)
case RTL_VER_13:
case RTL_VER_15:
case RTL_VER_16:
case RTL_VER_17:
if (enable) {
r8156_eee_en(tp, true);
ocp_reg_write(tp, OCP_EEE_ADV, tp->eee_adv);
@ -6408,7 +6417,7 @@ static int rtl8156_enable(struct r8152 *tp)
set_tx_qlen(tp);
rtl_set_eee_plus(tp);
if (tp->version >= RTL_VER_12 && tp->version <= RTL_VER_16)
if (tp->version >= RTL_VER_12 && tp->version <= RTL_VER_17)
ocp_word_clr_bits(tp, MCU_TYPE_USB, USB_RX_AGGR_NUM, RX_AGGR_NUM_MASK);
r8153_set_rx_early_timeout(tp);
@ -6817,7 +6826,7 @@ static void rtl8156_up(struct r8152 *tp)
return;
r8153b_u1u2en(tp, false);
if (tp->version != RTL_VER_16)
if (tp->version < RTL_VER_16)
r8153_u2p3en(tp, false);
r8153_aldps_en(tp, false);
@ -6831,7 +6840,7 @@ static void rtl8156_up(struct r8152 *tp)
ocp_byte_clr_bits(tp, MCU_TYPE_PLA, PLA_OOB_CTRL, NOW_IS_OOB);
if (tp->version == RTL_VER_16)
if (tp->version >= RTL_VER_16)
ocp_word_clr_bits(tp, MCU_TYPE_PLA, PLA_RCR1, BIT(3));
ocp_word_clr_bits(tp, MCU_TYPE_PLA, PLA_SFF_STS_7, MCU_BORW_EN);
@ -6856,7 +6865,7 @@ static void rtl8156_up(struct r8152 *tp)
ocp_word_clr_bits(tp, MCU_TYPE_PLA, PLA_MAC_PWR_CTRL3, PLA_MCU_SPDWN_EN);
if (tp->version != RTL_VER_16)
if (tp->version < RTL_VER_16)
ocp_word_clr_bits(tp, MCU_TYPE_USB, USB_SPEED_OPTION,
RG_PWRDN_EN | ALL_SPEED_OFF);
@ -6868,10 +6877,10 @@ static void rtl8156_up(struct r8152 *tp)
}
r8153_aldps_en(tp, true);
if (tp->version != RTL_VER_16)
if (tp->version < RTL_VER_16)
r8153_u2p3en(tp, true);
if (tp->version != RTL_VER_16 && tp->udev->speed >= USB_SPEED_SUPER)
if (tp->version < RTL_VER_16 && tp->udev->speed >= USB_SPEED_SUPER)
r8153b_u1u2en(tp, true);
}
@ -6886,7 +6895,7 @@ static void rtl8156_down(struct r8152 *tp)
PLA_MCU_SPDWN_EN);
r8153b_u1u2en(tp, false);
if (tp->version != RTL_VER_16) {
if (tp->version < RTL_VER_16) {
r8153_u2p3en(tp, false);
r8153b_power_cut_en(tp, false);
}
@ -7996,7 +8005,7 @@ static void r8157_hw_phy_cfg(struct r8152 *tp)
/* Advanced Power Saving parameter */
ocp_reg_set_bits(tp, 0xa430, BIT(0) | BIT(1));
/* aldpsce force mode */
/* Disable ALDPS force mode */
ocp_reg_clr_bits(tp, 0xa44a, BIT(2));
switch (tp->version) {
@ -8120,6 +8129,190 @@ static void r8157_hw_phy_cfg(struct r8152 *tp)
sram2_write_w0w1(tp, 0x807c, 0xff00, 0x5000);
sram2_write_w0w1(tp, 0x809d, 0xff00, 0x5000);
break;
case RTL_VER_17:
/* Disable bypass turn off clk in ALDPS */
ocp_byte_clr_bits(tp, MCU_TYPE_PLA, 0xd3c8, BIT(0));
/* Power level tuning
* test mode power level
*/
sram_write_w0w1(tp, 0x8415, 0xff00, 0x9300);
/* normal link power level 10G, 5G, 2.5G */
sram_write_w0w1(tp, 0x81a3, 0xff00, 0x0f00);
sram_write_w0w1(tp, 0x81ae, 0xff00, 0x0f00);
sram_write_w0w1(tp, 0x81b9, 0xff00, 0xb900);
/* normal link TX filter */
sram2_write_w0w1(tp, 0x83b0, 0x0e00, 0);
sram2_write_w0w1(tp, 0x83c5, 0x0e00, 0);
sram2_write_w0w1(tp, 0x83da, 0x0e00, 0);
sram2_write_w0w1(tp, 0x83ef, 0x0e00, 0);
/* AFE power saving for 2.5G & 5G */
sram_write(tp, 0x8173, 0x8620);
sram_write(tp, 0x8175, 0x8671);
sram_write_w0w1(tp, 0x817c, 0, BIT(13));
sram_write_w0w1(tp, 0x8187, 0, BIT(13));
sram_write_w0w1(tp, 0x8192, 0, BIT(13));
sram_write_w0w1(tp, 0x819d, 0, BIT(13));
sram_write_w0w1(tp, 0x81a8, BIT(13), 0);
sram_write_w0w1(tp, 0x81b3, BIT(13), 0);
sram_write_w0w1(tp, 0x81be, 0, BIT(13));
sram_write_w0w1(tp, 0x817d, 0xff00, 0xa600);
sram_write_w0w1(tp, 0x8188, 0xff00, 0xa600);
sram_write_w0w1(tp, 0x8193, 0xff00, 0xa600);
sram_write_w0w1(tp, 0x819e, 0xff00, 0xa600);
sram_write_w0w1(tp, 0x81a9, 0xff00, 0x1400);
sram_write_w0w1(tp, 0x81b4, 0xff00, 0x1400);
sram_write_w0w1(tp, 0x81bf, 0xff00, 0xa600);
/* RFI parameter
* disable preset FBE
*/
ocp_reg_clr_bits(tp, 0xaeaa, BIT(5) | BIT(3));
/* modify PGA for 5G&10G */
sram2_write(tp, 0x84f0, 0x201c);
sram2_write(tp, 0x84f2, 0x3117);
/* RFI parameter */
ocp_reg_write(tp, 0xaec6, 0x0000);
ocp_reg_write(tp, 0xae20, 0xffff);
ocp_reg_write(tp, 0xaece, 0xffff);
ocp_reg_write(tp, 0xaed2, 0xffff);
ocp_reg_write(tp, 0xaec8, 0x0000);
ocp_reg_clr_bits(tp, 0xaed0, BIT(0));
ocp_reg_write(tp, 0xadb8, 0x0150);
sram2_write_w0w1(tp, 0x8197, 0xff00, 0x5000);
sram2_write_w0w1(tp, 0x8231, 0xff00, 0x5000);
sram2_write_w0w1(tp, 0x82cb, 0xff00, 0x5000);
sram2_write_w0w1(tp, 0x82cd, 0xff00, 0x5700);
sram2_write_w0w1(tp, 0x8233, 0xff00, 0x5700);
sram2_write_w0w1(tp, 0x8199, 0xff00, 0x5700);
sram2_write(tp, 0x815a, 0x0150);
sram2_write(tp, 0x81f4, 0x0150);
sram2_write(tp, 0x828e, 0x0150);
sram2_write(tp, 0x81b1, 0x0000);
sram2_write(tp, 0x824b, 0x0000);
sram2_write(tp, 0x82e5, 0x0000);
sram2_write_w0w1(tp, 0x84f7, 0xff00, 0x2800);
ocp_reg_set_bits(tp, 0xaec2, BIT(12));
sram2_write_w0w1(tp, 0x81b3, 0xff00, 0xad00);
sram2_write_w0w1(tp, 0x824d, 0xff00, 0xad00);
sram2_write_w0w1(tp, 0x82e7, 0xff00, 0xad00);
ocp_reg_w0w1(tp, 0xae4e, 0x000f, 0x0001);
sram2_write_w0w1(tp, 0x82ce, 0xf000, 0x4000);
/* 5G shift sel, default = '04'
* 10G shift sel, default = '03'
*/
sram2_write_w0w1(tp, 0x83a5, 0xff00, 0x0400);
sram2_write_w0w1(tp, 0x83a6, 0xff00, 0x0400);
sram2_write_w0w1(tp, 0x83a7, 0xff00, 0x0400);
sram2_write_w0w1(tp, 0x83a8, 0xff00, 0x0400);
/* XG INRX parameters
* RC coefficients
*/
sram2_write(tp, 0x84ac, 0x0000);
sram2_write(tp, 0x84ae, 0x0000);
sram2_write(tp, 0x84b0, 0xf818);
sram2_write_w0w1(tp, 0x84b2, 0xff00, 0x6000);
/* Training AAGC PAR (with uc2 patch) */
sram2_write(tp, 0x8ffc, 0x6008);
sram2_write(tp, 0x8ffe, 0xf450);
/* DAC BGK */
sram2_write_w0w1(tp, 0x8015, 0, BIT(9));
sram2_write_w0w1(tp, 0x8016, 0, BIT(11));
sram2_write_w0w1(tp, 0x8fe6, 0xff00, 0x0800);
sram2_write(tp, 0x8fe4, 0x2114);
/* 10G PBO table */
sram2_write(tp, 0x8647, 0xa7b1);
sram2_write(tp, 0x8649, 0xbbca);
sram2_write_w0w1(tp, 0x864b, 0xff00, 0xdc00);
/* 2.5G ado power window size */
sram2_write_w0w1(tp, 0x8154, 0xc000, 0x4000);
sram2_write_w0w1(tp, 0x8158, 0xc000, 0);
/* 10G lock far */
sram2_write(tp, 0x826c, 0xffff);
sram2_write(tp, 0x826e, 0xffff);
/* XG INRX parameter */
sram2_write_w0w1(tp, 0x8872, 0xff00, 0x0e00);
sram_write_w0w1(tp, 0x8012, 0, BIT(11));
sram_write_w0w1(tp, 0x8012, 0, BIT(14));
ocp_reg_set_bits(tp, 0xb576, BIT(0));
sram_write_w0w1(tp, 0x834a, 0xff00, 0x0700);
sram2_write_w0w1(tp, 0x8217, 0x3f00, 0x2a00);
sram_write_w0w1(tp, 0x81b1, 0xff00, 0x0b00);
sram2_write_w0w1(tp, 0x8fed, 0xff00, 0x4e00);
/* Slave about EC mu of datamode AAGC and DAC BG */
sram2_write_w0w1(tp, 0x88ac, 0xff00, 0x2300);
/* improve UBE */
ocp_reg_set_bits(tp, 0xbf0c, 0x7 << 11);
/* close Sparse NEC, improve connect 5EUU cable performance */
sram2_write_w0w1(tp, 0x88de, 0xff00, 0);
/* 5G slave compatibility issue */
sram2_write(tp, 0x80b4, 0x5195);
/* XG Test Mode
* xgtstm_map_tbl for mdi_cap_sel
*/
sram_write(tp, 0x8370, 0x8671);
sram_write(tp, 0x8372, 0x86c8);
/* xgtstm_amp_map_tbl for REG_IBX_UP_SHIFT_L */
sram_write(tp, 0x8401, 0x86c8);
sram_write(tp, 0x8403, 0x86da);
sram_write_w0w1(tp, 0x8406, 0x1800, 0x1000);
sram_write_w0w1(tp, 0x8408, 0x1800, 0x1000);
sram_write_w0w1(tp, 0x840a, 0x1800, 0x1000);
sram_write_w0w1(tp, 0x840c, 0x1800, 0x1000);
sram_write_w0w1(tp, 0x840e, 0x1800, 0x1000);
sram_write_w0w1(tp, 0x8410, 0x1800, 0x1000);
sram_write_w0w1(tp, 0x8412, 0x1800, 0x1000);
sram_write_w0w1(tp, 0x8414, 0x1800, 0x1000);
sram_write_w0w1(tp, 0x8416, 0x1800, 0x1000);
/* Cable Test Patch */
sram_write(tp, 0x82bd, 0x1f40);
/* Thermal sensor parameters */
ocp_reg_w0w1(tp, 0xbfb4, 0x07ff, 0x0328);
ocp_reg_write(tp, 0xbfb6, 0x3e14);
/* spdchg_gtx_shape_100M */
ocp_reg_write(tp, OCP_SRAM_ADDR, 0x81c4);
ocp_reg_write(tp, OCP_SRAM_DATA, 0x003b);
ocp_reg_write(tp, OCP_SRAM_DATA, 0x0086);
ocp_reg_write(tp, OCP_SRAM_DATA, 0x00b7);
ocp_reg_write(tp, OCP_SRAM_DATA, 0x00db);
ocp_reg_write(tp, OCP_SRAM_DATA, 0x00fe);
ocp_reg_write(tp, OCP_SRAM_DATA, 0x00fe);
ocp_reg_write(tp, OCP_SRAM_DATA, 0x00fe);
ocp_reg_write(tp, OCP_SRAM_DATA, 0x00fe);
ocp_reg_write(tp, OCP_SRAM_DATA, 0x00c3);
ocp_reg_write(tp, OCP_SRAM_DATA, 0x0078);
ocp_reg_write(tp, OCP_SRAM_DATA, 0x0047);
ocp_reg_write(tp, OCP_SRAM_DATA, 0x0023);
/* lsbmsk_parameters
* RL6961_lsbmsk_parameter_250207
*/
sram2_write(tp, 0x88d7, 0x01a0);
sram2_write(tp, 0x88d9, 0x01a0);
sram2_write(tp, 0x8ffa, 0x002a);
sram2_write(tp, 0x8fee, 0xffdf);
sram2_write(tp, 0x8ff0, 0xffff);
sram2_write(tp, 0x8ff2, 0x0a4a);
sram2_write(tp, 0x8ff4, 0xaa5a);
sram2_write(tp, 0x8ff6, 0x0a4a);
sram2_write(tp, 0x8ff8, 0xaa5a);
sram2_write_w0w1(tp, 0x88d5, 0xff00, 0x0200);
break;
default:
break;
}
@ -8155,6 +8348,18 @@ static void r8157_hw_phy_cfg(struct r8152 *tp)
set_bit(PHY_RESET, &tp->flags);
}
static int r8159_wait_backup_restore(struct r8152 *tp)
{
u32 ocp_data;
ocp_data = ocp_read_word(tp, MCU_TYPE_USB, USB_MISC_0);
if (!(ocp_data & PCUT_STATUS))
return 0;
return poll_timeout_us(ocp_data = ocp_read_word(tp, MCU_TYPE_USB, USB_GPHY_CTRL),
ocp_data & BACKUP_RESTRORE, 200, 20000, false);
}
static void r8156_init(struct r8152 *tp)
{
u32 ocp_data;
@ -8164,14 +8369,14 @@ static void r8156_init(struct r8152 *tp)
if (test_bit(RTL8152_INACCESSIBLE, &tp->flags))
return;
if (tp->version == RTL_VER_16) {
if (tp->version == RTL_VER_16 || tp->version == RTL_VER_17) {
ocp_byte_set_bits(tp, MCU_TYPE_USB, 0xcffe, BIT(3));
ocp_byte_clr_bits(tp, MCU_TYPE_USB, 0xd3ca, BIT(0));
}
ocp_byte_clr_bits(tp, MCU_TYPE_USB, USB_ECM_OP, EN_ALL_SPEED);
if (tp->version != RTL_VER_16)
if (tp->version < RTL_VER_16)
ocp_write_word(tp, MCU_TYPE_USB, USB_SPEED_OPTION, 0);
ocp_word_set_bits(tp, MCU_TYPE_USB, USB_ECM_OPTION, BYPASS_MAC_RESET);
@ -8185,6 +8390,7 @@ static void r8156_init(struct r8152 *tp)
case RTL_VER_13:
case RTL_VER_15:
case RTL_VER_16:
case RTL_VER_17:
r8156b_wait_loading_flash(tp);
break;
default:
@ -8201,6 +8407,12 @@ static void r8156_init(struct r8152 *tp)
return;
}
if (tp->version == RTL_VER_17 && r8159_wait_backup_restore(tp)) {
rtl_set_inaccessible(tp);
dev_err(&tp->intf->dev, "init failed, backup-restore timed out\n");
return;
}
data = r8153_phy_status(tp, 0);
if (data == PHY_STAT_EXT_INIT) {
ocp_reg_clr_bits(tp, 0xa468, BIT(3) | BIT(1));
@ -8216,7 +8428,7 @@ static void r8156_init(struct r8152 *tp)
data = r8153_phy_status(tp, PHY_STAT_LAN_ON);
if (tp->version == RTL_VER_16)
if (tp->version >= RTL_VER_16)
r8157_u2p3en(tp, false);
else
r8153_u2p3en(tp, false);
@ -8227,7 +8439,7 @@ static void r8156_init(struct r8152 *tp)
/* U1/U2/L1 idle timer. 500 us */
ocp_write_word(tp, MCU_TYPE_USB, USB_U1U2_TIMER, 500);
if (tp->version == RTL_VER_16)
if (tp->version >= RTL_VER_16)
r8157_power_cut_en(tp, false);
else
r8153b_power_cut_en(tp, false);
@ -8260,7 +8472,7 @@ static void r8156_init(struct r8152 *tp)
r8156_mac_clk_spd(tp, true);
if (tp->version != RTL_VER_16)
if (tp->version < RTL_VER_16)
ocp_word_clr_bits(tp, MCU_TYPE_PLA, PLA_MAC_PWR_CTRL3, PLA_MCU_SPDWN_EN);
ocp_data = ocp_read_word(tp, MCU_TYPE_PLA, PLA_EXTRA_STATUS);
@ -8273,8 +8485,13 @@ static void r8156_init(struct r8152 *tp)
set_bit(GREEN_ETHERNET, &tp->flags);
/* rx aggregation / 16 bytes Rx descriptor */
if (tp->version == RTL_VER_16)
/* RX aggregation / 16 bytes RX descriptor
* BIT(11) is specific to RTL8159, with unknown meaning
*/
if (tp->version == RTL_VER_17)
ocp_word_clr_bits(tp, MCU_TYPE_USB, USB_USB_CTRL,
RX_AGG_DISABLE | RX_DESC_16B | BIT(11));
else if (tp->version == RTL_VER_16)
ocp_word_clr_bits(tp, MCU_TYPE_USB, USB_USB_CTRL, RX_AGG_DISABLE | RX_DESC_16B);
else
ocp_word_clr_bits(tp, MCU_TYPE_USB, USB_USB_CTRL, RX_AGG_DISABLE | RX_ZERO_EN);
@ -8282,7 +8499,7 @@ static void r8156_init(struct r8152 *tp)
if (tp->version < RTL_VER_12)
ocp_byte_set_bits(tp, MCU_TYPE_USB, USB_BMU_CONFIG, ACT_ODMA);
if (tp->version == RTL_VER_16) {
if (tp->version >= RTL_VER_16) {
/* Disable Rx Zero Len */
rtl_bmu_clr_bits(tp, 0x2300, BIT(3));
/* TX descriptor Signature */
@ -9670,6 +9887,29 @@ static int rtl_ops_init(struct r8152 *tp)
r8157_desc_init(tp);
break;
case RTL_VER_17:
tp->eee_en = true;
tp->eee_adv = MDIO_EEE_100TX | MDIO_EEE_1000T | MDIO_EEE_10GT;
tp->eee_adv2 = MDIO_EEE_2_5GT | MDIO_EEE_5GT;
ops->init = r8156_init;
ops->enable = rtl8156_enable;
ops->disable = rtl8153_disable;
ops->up = rtl8156_up;
ops->down = rtl8156_down;
ops->unload = rtl8153_unload;
ops->eee_get = r8153_get_eee;
ops->eee_set = r8152_set_eee;
ops->in_nway = rtl8153_in_nway;
ops->hw_phy_cfg = r8157_hw_phy_cfg;
ops->autosuspend_en = rtl8157_runtime_enable;
ops->change_mtu = rtl8156_change_mtu;
tp->rx_buf_sz = 48 * 1024;
tp->support_2500full = 1;
tp->support_5000full = 1;
tp->support_10000full = 1;
r8157_desc_init(tp);
break;
default:
ret = -ENODEV;
dev_err(&tp->intf->dev, "Unknown Device\n");
@ -9823,6 +10063,9 @@ static u8 __rtl_get_hw_ver(struct usb_device *udev)
case 0x1030:
version = RTL_VER_16;
break;
case 0x2020:
version = RTL_VER_17;
break;
default:
version = RTL_VER_UNKNOWN;
dev_info(&udev->dev, "Unknown version 0x%04x\n", ocp_data);
@ -9975,6 +10218,7 @@ static int rtl8152_probe_once(struct usb_interface *intf,
case RTL_VER_13:
case RTL_VER_15:
case RTL_VER_16:
case RTL_VER_17:
netdev->max_mtu = size_to_mtu(16 * 1024);
break;
case RTL_VER_01:
@ -10140,6 +10384,7 @@ static const struct usb_device_id rtl8152_table[] = {
{ USB_DEVICE(VENDOR_ID_REALTEK, 0x8155) },
{ USB_DEVICE(VENDOR_ID_REALTEK, 0x8156) },
{ USB_DEVICE(VENDOR_ID_REALTEK, 0x8157) },
{ USB_DEVICE(VENDOR_ID_REALTEK, 0x815a) },
/* Microsoft */
{ USB_DEVICE(VENDOR_ID_MICROSOFT, 0x07ab) },