From aca05dabcecc3c1887c72d4facd5d789c304bd93 Mon Sep 17 00:00:00 2001 From: Subbaraman Narayanamurthy Date: Wed, 30 Mar 2022 16:31:11 -0700 Subject: [PATCH] power: supply: qti_battery_charger: add an error log in wireless_fw_update() If wireless FW name is not specified for battery_charger device, then it's better to print an error log and bail out without requesting a firmware. Change-Id: Iaf384bee625b1ec69b87de6b5d309569b4b10a17 Signed-off-by: Subbaraman Narayanamurthy --- drivers/power/supply/qti_battery_charger.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/power/supply/qti_battery_charger.c b/drivers/power/supply/qti_battery_charger.c index a4866ef41e18..5127ab78bd67 100644 --- a/drivers/power/supply/qti_battery_charger.c +++ b/drivers/power/supply/qti_battery_charger.c @@ -1405,6 +1405,11 @@ static int wireless_fw_update(struct battery_chg_dev *bcdev, bool force) u16 maj_ver, min_ver; int rc; + if (!bcdev->wls_fw_name) { + pr_err("wireless FW name is not specified\n"); + return -EINVAL; + } + pm_stay_awake(bcdev->dev); /*