github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-27 17:47:41 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

netfs: Fix writeback error handling

Browse Source 
Fix the error handling in writeback_iter() loop.  If an error occurs,
writeback_iter() needs to be called again with *error set to the error so
that it can clean up iteration state.  Further, the current folio needs
unlocking and redirtying.

Fixes: 288ace2f57 ("netfs: New writeback implementation")
Link: https://sashiko.dev/#/patchset/20260619140646.2633762-1-dhowells%40redhat.com
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://patch.msgid.link/20260625140640.3116900-14-dhowells@redhat.com
cc: Paulo Alcantara <pc@manguebit.org>
cc: Matthew Wilcox <willy@infradead.org>
cc: netfs@lists.linux.dev
cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
This commit is contained in:
David Howells 2026-06-25 15:06:31 +01:00 committed by Christian Brauner
parent ba6a9f6533
commit ac5f95ac5d
No known key found for this signature in database
GPG Key ID: 91C61BC06578DCA2
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
fs/netfs/write_issue.c
View File

@ -582,8 +582,6 @@ int netfs_writepages(struct address_space *mapping,
}
error = netfs_write_folio(wreq, wbc, folio);
if (error < 0)
break;
} while ((folio = writeback_iter(mapping, wbc, folio, &error)));
netfs_end_issue_write(wreq);
@ -594,7 +592,14 @@ int netfs_writepages(struct address_space *mapping,
return error;
couldnt_start:
netfs_kill_dirty_pages(mapping, wbc, folio);
if (error == -ENOMEM) {
folio_redirty_for_writepage(wbc, folio);
folio_unlock(folio);
folio = writeback_iter(mapping, wbc, folio, &error);
WARN_ON_ONCE(folio != NULL);
} else {
netfs_kill_dirty_pages(mapping, wbc, folio);
}
out:
netfs_wb_end(ictx);
_leave(" = %d", error);